Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up::one::two: access_restricted #89

Merged

Conversation

Projects
None yet
3 participants
@RafiZz
Copy link
Contributor

RafiZz commented Jul 13, 2018

No description provided.

@RafiZz RafiZz force-pushed the RafiZz:master-port_access-restricted branch from 442e991 to b7c04de Jul 17, 2018

@RafiZz RafiZz force-pushed the RafiZz:master-port_access-restricted branch from b7c04de to b78bc42 Jul 17, 2018

RafiZz added some commits Jul 23, 2018

@ufaks

ufaks approved these changes Jul 23, 2018

@yelizariev
Copy link
Member

yelizariev left a comment

Documentation (all kind of) seems to be not updated.

and then click ``[Apply]`` button (adding ``group_sale_delivery_address``)

With this module installed:

* The user from previous example cannot increase his privileges. There is no ``Sales: Manager`` option for him, and also no ``Display 3 fields on sales orders: customer, invoice address, delivery address``
* The user from previous example cannot increase his privileges. There is no ``Sales: Manager`` option for him, and also no ``Customer Addresses``

This comment has been minimized.

Copy link
@yelizariev

yelizariev Jul 23, 2018

Member

Really?

There is no Sales: Manager option for him, and also no Customer Addresses

@@ -12,4 +12,4 @@ Typical usage of the module.

The superuser creates an administrator user without access group "Show Apps Menu" (see **access_apps** module). Then the administrator has access to settings, but not able to install new apps (without this module he can add himself to "Show Apps Menu" and get access to apps).

Tested on 10.0 5f0b7942d551f441aa41e75ee06f2dd163a9c6f6
Tested on 12.0 edd8bad5d97ee489e85504791c807f0099ef24b5

This comment has been minimized.

Copy link
@yelizariev

yelizariev Jul 23, 2018

Member

Are you sure?

The module makes impossible for administrator to set (and see) more access rights (groups) than he already has. The only partial exception of this rule is made if you are already a member of the 'Allow add implied groups from settings' security group. Then you are allowed to escalate your privileges but just from Settings menus (by means of group_XXX boolean fields of res.config.settings models views).

@RafiZz RafiZz force-pushed the RafiZz:master-port_access-restricted branch from 3a9280a to 701b0c8 Jul 24, 2018

@yelizariev yelizariev merged commit dad3e5b into it-projects-llc:master Jul 24, 2018

4 checks passed

ci/branches Branch names are correct
Details
ci/runbot runbot build 18912-89-701b0c (runtime 148s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at ?%
Details
@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Jul 24, 2018

👍

@RafiZz RafiZz deleted the RafiZz:master-port_access-restricted branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.