Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:tada::one::two: pos_custom_orderline_popup #685

Open

Conversation

@KolushovAlexandr
Copy link
Member

commented Jul 18, 2019

No description provided.

seller_id: this.$el.find('.seller_id').val(),
partner_id: this.$el.find('.partner_id').val(),
executor_id: this.$el.find('.executor_id').val(),
}

This comment has been minimized.

Copy link
@hound

hound bot Jul 18, 2019

Missing semicolon.

pos_custom_orderline_popup/static/src/js/pos.js Outdated Show resolved Hide resolved
'widget': orderline_customzation,
});

var orderline_customzation = PopupWidget.extend({

This comment has been minimized.

Copy link
@hound

hound bot Jul 18, 2019

'orderline_customzation' is already defined.

ilmir-k and others added 6 commits Jul 19, 2019
models.Order = models.Order.extend({
check_orderlines_data: function(){
return _.find(this.get_orderlines(), function(ol) {
return ol.not_filled_fields().length

This comment has been minimized.

Copy link
@hound

hound bot Jul 22, 2019

Missing semicolon.


not_filled_fields: function() {
var data = this.get_orderline_partner_data();
return _.without(mandatory_popup_fields, ..._.chain(data)

This comment has been minimized.

Copy link
@hound

hound bot Jul 22, 2019

'spread/rest operator' is only available in ES6 (use 'esversion: 6').

return data[key];
}).value();
if (filled_fields.length) {
var not_filled_fields = _.without(mandatory_popup_fields, ...filled_fields, 'partner_id');

This comment has been minimized.

Copy link
@hound

hound bot Jul 22, 2019

'spread/rest operator' is only available in ES6 (use 'esversion: 6').

if (updated_keys.length) {
partner_id = _.extend(
partner_id,
_.pick(data.partner_vals, ...updated_keys)

This comment has been minimized.

Copy link
@hound

hound bot Jul 22, 2019

'spread/rest operator' is only available in ES6 (use 'esversion: 6').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.