Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up::one::two: website_team #694

Open
wants to merge 1 commit into
base: website-addons-12.0-website_team
from

Conversation

@fedoranvar
Copy link

commented Aug 7, 2019

No description provided.

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch 2 times, most recently from 119a81a to 0cc7e5b Aug 8, 2019

fjs.parentNode.insertBefore(js, fjs);
t._e = [];
<odoo>
<template id="website_team_twitter" name="Website Team Twitter">

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 8, 2019

Member

Don't change indent please. Just replace <openerp><data> to <odoo>

<data>
<record id="view_users_form" model="ir.ui.view">
<field name="name">res.users.form</field>
<field name="model">res.users</field>
<field name="type">form</field>
<field name="inherit_id" ref="base.view_users_form"/>
<field name="arch" type="xml">
<xpath expr="//div[@class='oe_title']//field[@name='active']" position="after">
<xpath expr="//field[@name='active']" position="after">
<field name="website_published"/>

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 8, 2019

Member

I don't see this button at the form
image

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch 2 times, most recently from ff343f0 to 7e30cfa Aug 8, 2019

yelizariev added a commit that referenced this pull request Aug 10, 2019
Merge pull request #694 from Rusllan/10.0-manifest-renaming
🌈 all the __openerp__.py files renamed in __manifest__.py

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch 10 times, most recently from d5409df to f3f6fee Aug 12, 2019

@@ -13,7 +13,8 @@ Credits

Contributors
------------
* Kolushov Alexandr <kolushov@it-projects.info>
* `Kolushov Alexandr <https://it-projects.info/team/KolushovAlexandr>`__
* `Anvar Kildebekov <https://it-projects.info/team/kildebekov>`__

This comment has been minimized.

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch from f3f6fee to 068a1e5 Aug 13, 2019

@KolushovAlexandr
Copy link
Member

left a comment

I can suggest redoing <field name="website_published"/> as a smart button such as Active for better appearence

@@ -42,8 +40,8 @@ def get_youtube_id(self, link):
return "https://www.youtube.com/embed/" + link_id + "?rel=0&amp;showinfo=0"

def get_alias_mail(self):
if self.alias_name:
alias_email_full = self.alias_name + "@" + self.alias_domain
if self.login:

This comment has been minimized.

Copy link
@KolushovAlexandr

KolushovAlexandr Aug 14, 2019

Member

the whole function could be converted into the one return string

@KolushovAlexandr
Copy link
Member

left a comment

Incorrect commit message. Please make the suggestion about simplification of the get_alias_mail function

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch from 068a1e5 to 2a968b8 Aug 14, 2019

@fedoranvar fedoranvar changed the title :arrow_up::one::two: :arrow_up::one::two: website_team Aug 15, 2019

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch from 2a968b8 to 69300b5 Aug 15, 2019

@KolushovAlexandr
Copy link
Member

left a comment

You forget about this travis error

======== Testing test_flake8 ========
website_team/models/team.py:45:1: E302 expected 2 blank lines, found 1

Then, about it
https://github.com/it-projects-llc/addons-dev/compare/2a968b83129a37b524759c5330089b6eb5b88d82..69300b5571f0108e53993d0e26c7c0775f5e0619
I dont see any proper description in index.html, If you was not said to do it better remove it. It is a work for Technical Writers

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch 2 times, most recently from 029b970 to 4119b63 Aug 15, 2019

@Ramil-Mukhametzyanov
Copy link
Member

left a comment

  1. The team page has a link to itself (at the bottom).
  2. The page is empty even if the github field is filled for a user.

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch from 4119b63 to a64c420 Aug 26, 2019

# "demo_images": [
# "images/MAIN_IMAGE",
# ]
}

This comment has been minimized.

Copy link
@hound

hound bot Aug 26, 2019

blank line at end of file

@kaadevelop
Copy link
Member

left a comment

2 modules are updated:

Updated files in 2 installable modules:

├─ category_module_for_very_okay/
|  ├─ README.rst
|  ├─ __init__.py
|  ├─ __manifest__.py
|  ├─ doc/
|  |  ├─ changelog.rst
|  |  └─ index.rst
|  └─ static/
|     └─ description/
|        └─ icon.png
└─ website_team/
   ├─ README.rst
   ├─ __init__.py
   ├─ __manifest__.py
   ├─ controllers/
   |  ├─ __init__.py
   |  └─ main.py
   ├─ images/
   |  └─ website_team.png
   ├─ models/
   |  ├─ __init__.py
   |  └─ team.py
   └─ views/
      ├─ website_team_template.xml
      └─ website_team_view.xml

Updated files in 0 non-installable modules:
are absent

You can use this review-bot too. Look: https://odoo-devops.readthedocs.io/en/latest/

`1.0.0`
-------

- **Init version**

This comment has been minimized.

Copy link
@kaadevelop

kaadevelop Aug 26, 2019

Member

Has to be tested

@fedoranvar fedoranvar force-pushed the fedoranvar:website-addons-12.0-website_team branch from a64c420 to c1f0e91 Aug 26, 2019

@em230418
Copy link
Member

left a comment

  • Редактируем demo, выставляем какое-нибудь значение в поле Github, сохраняем
  • Заходим на /team/demo. Ссылка поменялась на ту, которую ввели в github
  1. Для полей github, upwork link и twitter link нету никаких проверок типа той, которая реализована для youtube

  2. Предлагаю поле Github поменять на Github user, т.к. непонятно, надо вводить ссылку на профиль или логин пользователя

  3. Покрыть тестами 1 и 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.