Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 odoo_backup_sh bugfixes and doc fixes #695

Conversation

@em230418
Copy link
Member

commented Aug 7, 2019

No description provided.

odoo_backup_sh/controllers/main.py Outdated Show resolved Hide resolved
odoo_backup_sh/controllers/main.py Outdated Show resolved Hide resolved
odoo_backup_sh/doc/index.rst Outdated Show resolved Hide resolved
odoo_backup_sh/doc/index.rst Outdated Show resolved Hide resolved
odoo_backup_sh_dropbox/doc/index.rst Outdated Show resolved Hide resolved

@em230418 em230418 force-pushed the em230418:misc-addons-12.0-odoo_backup_sh-bugfixes branch from 2f52a31 to ad17044 Aug 13, 2019

@em230418

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@Mirgalimova @yelizariev I removed downloading notes from odoo_backup_sh_dropbox and odoo_backup_sh_google_disk and changed note in odoo_backup_sh. It is planned, that instructions given in last one will work for 2 others.

@em230418 em230418 force-pushed the em230418:misc-addons-12.0-odoo_backup_sh-bugfixes branch from ad17044 to 7872d83 Aug 13, 2019

@em230418 em230418 force-pushed the em230418:misc-addons-12.0-odoo_backup_sh-bugfixes branch 4 times, most recently from bd2f78f to e2c6975 Aug 14, 2019

odoo_backup_sh/security/security.xml Outdated Show resolved Hide resolved

@em230418 em230418 force-pushed the em230418:misc-addons-12.0-odoo_backup_sh-bugfixes branch from e2c6975 to a770813 Aug 19, 2019

@em230418 em230418 force-pushed the em230418:misc-addons-12.0-odoo_backup_sh-bugfixes branch from a770813 to cfd108a Aug 20, 2019

yelizariev and others added 3 commits Aug 20, 2019
@yelizariev
Copy link
Member

left a comment

I'm not sure that this is correct. len(backup) probably returns len(ids), which is always 1 here, while the record may not exist. Instead of that, you need to use len(backup.exists()).

I was wrong saying that search and browse is the same. It's so only when ORM read it from database, which doesn't happen immediatly


    backup = env['odoo_backup_sh.backup_info'].browse(backup_id)
    if len(backup) == 0:

@yelizariev yelizariev merged commit d7d2562 into it-projects-llc:misc-addons-12.0-odoo_backup_sh Aug 20, 2019

3 of 4 checks passed

Travis CI - Pull Request Build Errored
Details
Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 03848-695-ce8495 (runtime 98s)
Details
@em230418

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

I'm not sure that this is correct. len(backup) probably returns len(ids), which is always 1 here, while the record may not exist.

https://github.com/odoo/odoo/blob/94a2c54fb50e39e3343f3183ead2121940ed0878/odoo/models.py#L4980-L4982

It does not always return 1. At least in 12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.