New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mail addons #127

Merged
merged 23 commits into from Jan 12, 2018

Conversation

Projects
None yet
4 participants
@ArtyomLosev
Copy link
Contributor

ArtyomLosev commented Nov 28, 2017

No description provided.

ArtyomLosev added some commits Nov 28, 2017

@yelizariev
Copy link
Member

yelizariev left a comment

No need to change version after porting

ArtyomLosev added some commits Nov 29, 2017

# wait till page loaded
code = """
setTimeout(function () {
console.log('ok');

This comment has been minimized.

@yelizariev

yelizariev Nov 29, 2017

Member

Add a check, that there is really a "To:" information and log error if it's not

console.log('error')

This comment has been minimized.

@yelizariev

yelizariev Nov 30, 2017

Member

I was wrong. It will throw error Cannot read property 'click' of undefined

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 29, 2017

Wrong usage of [FIX] and [PORT] tags. Check guidelines
http://odoo-development.readthedocs.io/en/latest/git/commits.html

ArtyomLosev added some commits Nov 30, 2017

chat_manager.get_domain = function (channel) {
return (channel.id === "channel_archive")
? ['|', ['partner_ids', 'in', [session.partner_id]],
['author_id.user_ids', 'in', [session.uid]]]

This comment has been minimized.

@yelizariev

yelizariev Dec 1, 2017

Member

Can you use domain without user_ids?

? ['|', ['partner_ids', 'in', [session.partner_id]],
    ['author_id', 'in', [session.partner_id]]]

ArtyomLosev added some commits Dec 1, 2017

@yelizariev
Copy link
Member

yelizariev left a comment

mail_reply doesn't work


Uncaught TypeError: Cannot read property 'url' of undefined
http://11577-127-37251d-base.runbot.it-projects.info/web/static/src/js/core/session.js:341
Traceback:
TypeError: Cannot read property 'url' of undefined
    at http://11577-127-37251d-base.runbot.it-projects.info/web/static/src/js/core/session.js:341:27
    at http://11577-127-37251d-base.runbot.it-projects.info/web/static/lib/jquery/jquery.js:3276:89
    at fire (http://11577-127-37251d-base.runbot.it-projects.info/web/static/lib/jquery/jquery.js:3119:58)
    at Object.add [as done] (http://11577-127-37251d-base.runbot.it-projects.info/web/static/lib/jquery/jquery.js:3165:49)
    at Array.<anonymous> (http://11577-127-37251d-base.runbot.it-projects.info/web/static/lib/jquery/jquery.js:3275:77)
    at Function.each (http://11577-127-37251d-base.runbot.it-projects.info/web/static/lib/jquery/jquery.js:383:58)
    at Object.<anonymous> (http://11577-127-37251d-base.runbot.it-projects.info/web/static/lib/jquery/jquery.js:3272:56)
    at Function.Deferred (http://11577-127-37251d-base.runbot.it-projects.info/web/static/lib/jquery/jquery.js:3332:30)
    at Object.then (http://11577-127-37251d-base.runbot.it-projects.info/web/static/lib/jquery/jquery.js:3271:55)
    at Class.rpc (http://11577-127-37251d-base.runbot.it-projects.info/web/static/src/js/core/session.js:337:40)```
code = """
setTimeout(function () {
$(".fa fa-reply.o_thread_icon.o_thread_message_reply").click();
setTimeout(function () {console.log('ok');}, 3000);

This comment has been minimized.

@yelizariev

yelizariev Dec 1, 2017

Member

Add sending a message

  • type something
  • click Send
  • wait extra few seconds

@ArtyomLosev ArtyomLosev force-pushed the ArtyomLosev:11.0-mail_addons branch from e09e910 to 7742b04 Dec 19, 2017

ArtyomLosev and others added some commits Dec 20, 2017

[TEXT] more explanation
of usage mail.compose.message
@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Dec 20, 2017

@ArtyomLosev fix conflicts

@yelizariev
Copy link
Member

yelizariev left a comment

Test was not debugged and doesn't work

# wait till page loaded and then click and wait again
code = """
setTimeout(function () {
$(".fa fa-reply.o_thread_icon.o_thread_message_reply").click();

This comment has been minimized.

@yelizariev

yelizariev Dec 20, 2017

Member

You has to be sure, that you click on a message, that normally doesn't have Reply button

console.log('ok');
}, 3000);
}, 3000);
}, 1000);

This comment has been minimized.

@yelizariev

yelizariev Dec 20, 2017

Member

I run this code, but it did nothing and only prints "ok"

$("o_input o_composer_text_field")
.val($('o_input o_composer_text_field').val()+ "test");
$("btn btn-sm btn-primary o_composer_button_send hidden-xs").click();

This comment has been minimized.

@yelizariev

yelizariev Dec 20, 2017

Member

You must check that there is a visible button (e.g. via $("...:visible").length and log error otherwise

$("btn btn-sm btn-primary o_composer_button_send hidden-xs").click();
setTimeout(function () {
console.log('ok');

This comment has been minimized.

@yelizariev

yelizariev Dec 20, 2017

Member

You must be sure, that the message is really sent. E.g. you can check that there is visible alert


<div class="alert o_mail_snackbar" data-dismiss="alert" role="alert" style="display: none;">
            Message sent in "false".
        </div>

ArtyomLosev added some commits Dec 20, 2017

@ArtyomLosev ArtyomLosev force-pushed the ArtyomLosev:11.0-mail_addons branch from a0af84c to 6b8767e Dec 20, 2017

@Railia

Railia approved these changes Dec 22, 2017

Copy link
Contributor

Railia left a comment

Everything works

@Railia
Copy link
Contributor

Railia left a comment

Sorry, no approve! I've noticed when I click on popup box to read message, it doesn't go to that box (inbox, channel..e.t.c). In Odoo 10 it works properly.

This was referenced Dec 26, 2017

@Railia

This comment has been minimized.

Copy link
Contributor

Railia commented Jan 9, 2018

@ArtyomLosev Issue occurs after mail_base installing

@Railia

Railia approved these changes Jan 12, 2018

Copy link
Contributor

Railia left a comment

It works!

@ilmir-k ilmir-k merged commit 7de69b0 into it-projects-llc:11.0 Jan 12, 2018

4 checks passed

ci/branches Branch names are correct
Details
ci/runbot runbot build 12719-127-492557 (runtime 225s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+38.3%) to 82.759%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment