Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up::one::two: mail_all #166

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@KolushovAlexandr
Copy link
Member

KolushovAlexandr commented Nov 23, 2018

No description provided.

_makeMessage: function (data) {
var message = this._super(data);
message._addThread('mailbox_channel_all');
return message

This comment has been minimized.

Copy link
@hound

hound bot Nov 23, 2018

Missing semicolon.

_getThreadDomain: function () {
if (this._id === 'mailbox_channel_all') {
return [];
} else {

This comment has been minimized.

Copy link
@hound

hound bot Nov 23, 2018

Unnecessary 'else' after 'return' no-else-return

_makeMessage: function (data) {
var message = this._super(data);
message._addThread('mailbox_channel_all');
return message

This comment has been minimized.

Copy link
@hound

hound bot Nov 23, 2018

Missing semicolon semi

},

_makeMessage: function (data) {
var message = this._super(data);

This comment has been minimized.

Copy link
@hound

hound bot Nov 23, 2018

Multiple spaces found before 'this' no-multi-spaces

_makeMessage: function (data) {
var message = this._super(data);
message._addThread('mailbox_channel_all');
return message

This comment has been minimized.

Copy link
@hound

hound bot Nov 23, 2018

Missing semicolon.

_getThreadDomain: function () {
if (this._id === 'mailbox_channel_all') {
return [];
} else {

This comment has been minimized.

Copy link
@hound

hound bot Nov 23, 2018

Unnecessary 'else' after 'return' no-else-return

_makeMessage: function (data) {
var message = this._super(data);
message._addThread('mailbox_channel_all');
return message

This comment has been minimized.

Copy link
@hound

hound bot Nov 23, 2018

Missing semicolon semi

},

_makeMessage: function (data) {
var message = this._super(data);

This comment has been minimized.

Copy link
@hound

hound bot Nov 23, 2018

Multiple spaces found before 'this' no-multi-spaces

@KolushovAlexandr KolushovAlexandr force-pushed the KolushovAlexandr:12.0-mail_all-port branch 2 times, most recently from 226382a to 97f4429 Nov 23, 2018

@KolushovAlexandr KolushovAlexandr force-pushed the KolushovAlexandr:12.0-mail_all-port branch from 97f4429 to 0a5533f Nov 23, 2018

@yelizariev
Copy link
Member

yelizariev left a comment

Code looks ok

@ilmir-k ilmir-k merged commit 08a339e into it-projects-llc:12.0 Nov 27, 2018

4 checks passed

Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 24650-166-f80d95 (runtime 158s)
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.