Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:ambulance: mail from channels were not visible #210

Merged

Conversation

@KolushovAlexandr
Copy link
Member

commented Jul 3, 2019

No description provided.

@KolushovAlexandr KolushovAlexandr force-pushed the KolushovAlexandr:12.0-mail_archives-issue branch from 5944346 to 5902a49 Jul 5, 2019

mail_sent/static/src/js/sent.js Outdated Show resolved Hide resolved
mail_sent/static/src/js/sent.js Outdated Show resolved Hide resolved
mail_archives/static/src/js/archives.js Outdated Show resolved Hide resolved
mail_archives/static/src/js/archives.js Outdated Show resolved Hide resolved

@KolushovAlexandr KolushovAlexandr force-pushed the KolushovAlexandr:12.0-mail_archives-issue branch 2 times, most recently from c79ca4b to 0edd44b Jul 5, 2019

@em230418

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

  1. во вкладке All messages сообщения группируются по дате, со своеобразным порядком. В тех, где указана дата, тогда - по порядку. Причем в одной группировке может "втиснуться" группа "Today"
    FireShot Capture 7 - Odoo

  2. Среди сообщений есть шапки вида

YourCompany, Marc Demo - 3 days ago (from #)

Если нажать на эту решетку, то во в каналах появляется #sales, в этих самих шапках решетка # преобразуется в #sales. Если выйти из канала #sales, то в шапках снова будет показываеться #.

  1. В документации есть места, где ссылаются ссылаются на 11 версию.

  2. Во вкладке All messages в шапках личных сообщений отмечается, что как-будто отправлено с канала. См. пример с #OdooBot.
    FireShot Capture 8 - Inbox - Odoo
    Предполагаю, что там должно быть, к примеру просто OdooBot или @OdooBot или Private messages или подобное.

Для воспроизводства выполнил следующую команду:

docker-compose run dodoo -- init --new-database db --demo -m web_tour,web,mail,base_setup,bus,base,mail_all,mail_archives
docker-compose up odoo

Предполагается, что проект развернут через odooup.

@ilmir-k

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@em230418
it seems that the problems are not related to the updates made so we can skip it.

@Ramil-Mukhametzyanov have you tested it?

@Ramil-Mukhametzyanov
Copy link
Member

left a comment

Only message sent to channels are added to the "Sent" mail thread.

@KolushovAlexandr KolushovAlexandr force-pushed the KolushovAlexandr:12.0-mail_archives-issue branch from 0edd44b to 6af60e5 Jul 14, 2019

mail_sent/models.py Outdated Show resolved Hide resolved
mail_sent/models.py Outdated Show resolved Hide resolved
mail_sent/models.py Outdated Show resolved Hide resolved
mail_sent/models.py Outdated Show resolved Hide resolved

@KolushovAlexandr KolushovAlexandr force-pushed the KolushovAlexandr:12.0-mail_archives-issue branch from 6af60e5 to 3a44a77 Jul 14, 2019

@Ramil-Mukhametzyanov
Copy link
Member

left a comment

The main error is fixed. However, there are still some errors in modules.

@Ramil-Mukhametzyanov
Copy link
Member

left a comment

If I send a message to a channel, the channel counter will not be updated.
If I send a message to an internal user (Demo) and his channel, the inbox counter will be equal to 2, but there is only one message.

@ilmir-k ilmir-k merged commit 5d0ce48 into it-projects-llc:12.0 Jul 15, 2019

7 checks passed

Hound No violations found. Woof!
Travis CI - Pull Request Build Passed
Details
ci/branches Branch names are correct
Details
ci/runbot runbot build 01233-210-3a44a7 (runtime 135s)
Details
codecov/patch/backend Coverage not affected when comparing e5a7e22...3a44a77
Details
codecov/patch/tests Coverage not affected when comparing e5a7e22...3a44a77
Details
coverage/coveralls Coverage increased (+0.08%) to 89.922%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.