Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up::one::two: web_debranding #633

Merged

Conversation

Projects
None yet
4 participants
@RafiZz
Copy link
Contributor

RafiZz commented Jul 23, 2018

No description provided.

16. Deletes "Odoo" in a request message for permission desktop notifications (yellow block at ``Discuss`` page). Replaces "Odoo" and icon in desktop notifications
17. [ENTERPRISE] Deletes odoo logo in application switcher
18. Hides Enterprise features in Settings
19. Replaces "Odoo" in all backend qweb templates

This provides a big part of debranding. You can find examples at menu ``[[ Settings ]] >> Dashboard`` in *Implementation* section
This provides a big part of debranding. You can find examples at menu ``[[ Invoicing ]] >> Dashboard >> Reconcile 5 items >> 'Automatic reconcilation' button title on hover``

This comment has been minimized.

Copy link
@yelizariev

yelizariev Jul 24, 2018

Member

Try to find example, that doesn't require installation of extra modules

This comment has been minimized.

Copy link
@ufaks

ufaks Jul 25, 2018

Contributor

All examples in depended modules are replaced/hided via other ways in this module

This comment has been minimized.

Copy link
@yelizariev
@@ -12,8 +12,6 @@
'depends': [
'web',
'mail',
'web_planner',
'access_apps',

This comment has been minimized.

Copy link
@yelizariev

yelizariev Jul 24, 2018

Member

Why do you remove access_apps? If it's temporarily, you must comment it out instead

This comment has been minimized.

Copy link
@RafiZz

RafiZz Jul 24, 2018

Author Contributor

I deleted access_app because the access_settings_menu's dependencies contain access_apps.

This comment has been minimized.

Copy link
@yelizariev

@api.model
def super_clear_caches(self):
super(IrTranslation, self).clear_caches()

This comment has been minimized.

Copy link
@yelizariev

yelizariev Jul 24, 2018

Member

It's not obvious why you call it via super. Add a code comment about it

we wrapped it in the api.model decorator
"""
super(IrTranslation, self).clear_caches()

This comment has been minimized.

Copy link
@yelizariev

yelizariev Jul 27, 2018

Member

Why it's super and not just self.clear_caches()?

return this._super.apply(this, arguments);
},

/**

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 2, 2018

Missing JSDoc return description valid-jsdoc

msg.avatar_src = '/web/binary/company_logo?company_id=' + session.company_id;
msg.displayed_author = 'Bot';
Message.include({
/**

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Aug 2, 2018

Missing JSDoc return description valid-jsdoc

@RafiZz RafiZz force-pushed the RafiZz:master-port-web_debranding branch from a959f59 to 45dbe39 Aug 2, 2018

@@ -82,3 +81,11 @@ def get_field_string(self, model_name):
def get_field_help(self, model_name):
res = super(IrTranslation, self).get_field_help(model_name)
return self._debrand_dict(res)

@api.model
def super_clear_caches(self):

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 3, 2018

Member

word super in method name doesn't seem to be relevant

@api.model
def super_clear_caches(self):
"""For calling clear_caches from via xml <function ... />
we wrapped it in the api.model decorator

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 3, 2018

Member

Actually, it's ok

<odoo><data>
</data></odoo>
<odoo>
</odoo>

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 3, 2018

Member

Maybe just remove the file 😉

@RafiZz RafiZz force-pushed the RafiZz:master-port-web_debranding branch from 3d9c6ab to 35f30a0 Aug 3, 2018

RafiZz added some commits Aug 6, 2018

@RafiZz RafiZz force-pushed the RafiZz:master-port-web_debranding branch from 399de87 to bee9d4c Aug 6, 2018

@ufaks

ufaks approved these changes Aug 6, 2018

@yelizariev
Copy link
Member

yelizariev left a comment

👍

@yelizariev yelizariev merged commit 554219a into it-projects-llc:master Aug 6, 2018

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 19415-633-bee9d4 (runtime 311s)
Details
coverage/coveralls Coverage increased (+2.3%) to 53.95%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.