New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 merge 11.0 #668

Merged
merged 104 commits into from Oct 19, 2018

Conversation

Projects
None yet
@yelizariev
Member

yelizariev commented Oct 19, 2018

No description provided.

yelizariev and others added some commits Mar 29, 2018

[FIX] base_import_map: prevent duplicate map settings controls
Because in the custom init function the original (prototype) 'opts' array
was mutated, every time the function was called (which happens everytime one
opens the import wizard) 3 opts were added, resulting in duplicate map
controls.
Solve the bug by using concat + reassignment instead of mutation.
[PORT] remove utf-8
it's not needed in python 3
[FIX] ir_attachment_s3: not superusers cannot store chatter attachmen…
…ts on s3 - search by user (not admin) didn't find the attachment, also s3_rerords.filtered('datas') filtered out the attachment - no datas if you are not a superuser somehow
[FIX] ir_attachment_s3: the datas field has got empty in sudo() searc…
…h unless you are a superuser. Search without sudo() doesn't find the record itself

yelizariev and others added some commits Aug 24, 2018

📖 no need to update module on uninstalling
It was needed before when column is deleted
⚡️ _get_company checks context fro website
(it was in website_multi_company before)
⚡️ default record for existing models in reference field (#653)
* ⚡️ default record for existing models in reference field

* 🌹 explain why we need to set it after changing model

* 🌹 explanation for overriding web client method
🌈 remove unnecessary code + fix context
(use force_company instead of company_id in context)
🚑 Comparing apples and oranges
ir.actions.report(287,) == 287
🌈 CI errors (#662)
Conflicts:
	theme_kit/__init__.py
	theme_kit/__openerp__.py
	theme_kit/models/res_config.py
	theme_kit/models/theme.py
🆘1️⃣2️⃣ mark as uninstallable to review
* some dependencies has to be fixed
* web_debranding itself has to be checked again as previous porting was against
  master version
{name: 'settings', label: _lt("Settings:"), value: ''},
{name: 'save_settings', label: _lt("Save settings:"), value: ''},
{name: 'file_read_hook', label: _lt("File read hook:"), value: ''}
])

This comment has been minimized.

@houndci-bot

houndci-bot Oct 19, 2018

Missing semicolon.

{name: 'settings', label: _lt("Settings:"), value: ''},
{name: 'save_settings', label: _lt("Save settings:"), value: ''},
{name: 'file_read_hook', label: _lt("File read hook:"), value: ''}
])

This comment has been minimized.

@houndci-bot

houndci-bot Oct 19, 2018

Missing semicolon semi

if (this.attendance) {
this.attendance.check_out
? this.farewell_message()
: this.welcome_message();

This comment has been minimized.

@houndci-bot

houndci-bot Oct 19, 2018

Expected an assignment or function call and instead saw an expression.

start: function() {
if (this.attendance) {
this.attendance.check_out
? this.farewell_message()

This comment has been minimized.

@houndci-bot

houndci-bot Oct 19, 2018

Misleading line break before '?'; readers may interpret this as an expression boundary.

@yelizariev yelizariev merged commit 033bd05 into it-projects-llc:12.0 Oct 19, 2018

3 of 4 checks passed

ci/runbot runbot build 22387-668-4db1e6 (runtime 483s)
Details
Hound 4 violations found.
ci/branches Branch names are correct
Details
coverage/coveralls Coverage increased (+6.5%) to 60.474%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment