New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up::one::two: web_website #669

Merged
merged 2 commits into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@yelizariev
Member

yelizariev commented Oct 23, 2018

No description provided.

_onClick: function (ev) {
ev.preventDefault();
var website_id = $(ev.currentTarget).data('website-id') || false; // write method ignores undefinded
this._rpc({

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

Unexpected whitespace before property then no-whitespace-before-property

*/
_onClick: function (ev) {
ev.preventDefault();
var website_id = $(ev.currentTarget).data('website-id') || false; // write method ignores undefinded

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

Multiple spaces found before '// write metho...' no-multi-spaces
Unexpected comment inline with code no-inline-comments

/**
* @private
* @param {MouseEvent} ev

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

Missing JSDoc parameter description for 'ev' valid-jsdoc

// Handlers
//--------------------------------------------------------------------------
/**

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

Missing JSDoc @returns for function valid-jsdoc

else {
if (current_website)
self.$('.oe_topbar_name').text(current_website[1]);
else

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

Expected { after 'else' curly

_t('Tap on the list to change website') + '</li>';
}
else {
if (current_website)

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

Expected { after 'if' condition curly
Unexpected if as the only statement in an else block no-lonely-if

if (this.isMobile) {
websites_list = '<li class="bg-info">' +
_t('Tap on the list to change website') + '</li>';
}

This comment has been minimized.

@houndci-bot

houndci-bot Oct 23, 2018

Closing curly brace does not appear on the same line as the subsequent block brace-style

Show resolved Hide resolved web_website/static/src/js/switch_website_menu.js

yelizariev added some commits Oct 23, 2018

@yelizariev yelizariev merged commit 091c897 into it-projects-llc:12.0 Nov 14, 2018

2 of 3 checks passed

ci/runbot runbot build 23908-669-b1332f
Details
Hound 3 violations found.
ci/branches Branch names are correct
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment