Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up::one::two: ir_attachment_s3 #675

Closed

Conversation

Projects
None yet
4 participants
@RafiZz
Copy link
Contributor

commented Oct 31, 2018

No description provided.

@RafiZz RafiZz force-pushed the RafiZz:12.0-port-ir_attachment_s3 branch 2 times, most recently from 828642d to 1650717 Oct 31, 2018

RafiZz and others added some commits Oct 31, 2018

🚑 when the "image_resize_image" function was called, they received th…
…e error "binascii.Error: decoding with base64 codec failed (Error: Incorrect padding)", since the value of the binary field is the URL, not the base_64 string

@RafiZz RafiZz force-pushed the RafiZz:12.0-port-ir_attachment_s3 branch from 91a9e2d to 58d98c4 Nov 6, 2018

@yelizariev

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

It will be checked after #674

@RafiZz RafiZz force-pushed the RafiZz:12.0-port-ir_attachment_s3 branch from 58d98c4 to b93d0f7 Dec 6, 2018

tools.image_resize_image_big = image_resize_image_big
tools.image_resize_image_medium = image_resize_image_medium
tools.image_resize_image_small = image_resize_image_small
>>>>>>> :ambulance: when the "image_resize_image" function was called, they received the error "binascii.Error: decoding with base64 codec failed (Error: Incorrect padding)", since the value of the binary field is the URL, not the base_64 string

This comment has been minimized.

Copy link
@hound

hound bot Dec 6, 2018

missing whitespace after ':'
missing whitespace around operator
whitespace before ':'

@@ -91,3 +92,44 @@ def updated_image_get_resized_images(base64_source, return_big=False, return_med
tools.image_resize_image_medium = updated_image_resize_image_medium
tools.image_resize_image_small = updated_image_resize_image_small
tools.image_get_resized_images = updated_image_get_resized_images
=======
def image_resize_image_decorator(original_image_resize_image):

This comment has been minimized.

Copy link
@hound

hound bot Dec 6, 2018

expected 2 blank lines, found 0

@@ -91,3 +92,44 @@ def updated_image_get_resized_images(base64_source, return_big=False, return_med
tools.image_resize_image_medium = updated_image_resize_image_medium
tools.image_resize_image_small = updated_image_resize_image_small
tools.image_get_resized_images = updated_image_get_resized_images
=======

This comment has been minimized.

Copy link
@hound

hound bot Dec 6, 2018

missing whitespace around operator

@@ -31,6 +31,7 @@ def is_url(value):
return isinstance(value, str) and re.findall(r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+', value)


<<<<<<< 3afb3ec08537d0b89d15d66f12b7f9aef57de5eb

This comment has been minimized.

Copy link
@hound

hound bot Dec 6, 2018

SyntaxError: invalid syntax
missing whitespace around bitwise or shift operator
missing whitespace around operator

"version": "12.0.1.1.6",
=======
"version": "12.0.1.1.5",
>>>>>>> :arrow_up::one::two: ir_attachment_url

This comment has been minimized.

Copy link
@hound

hound bot Dec 6, 2018

continuation line missing indentation or outdented
missing whitespace after ':'
missing whitespace around operator
whitespace before ':'

"version": "12.0.1.1.6",
=======

This comment has been minimized.

Copy link
@hound

hound bot Dec 6, 2018

continuation line missing indentation or outdented
missing whitespace around operator

@@ -3,7 +3,11 @@
"summary": """Use attachment URL and upload data to external storage""",
"category": "Tools",
"images": [],
<<<<<<< 65ab33520a0f2a307600a8a5924dcd7f07022d20

This comment has been minimized.

Copy link
@hound

hound bot Dec 6, 2018

SyntaxError: invalid syntax
continuation line missing indentation or outdented
missing whitespace around bitwise or shift operator
missing whitespace around operator

@RafiZz RafiZz force-pushed the RafiZz:12.0-port-ir_attachment_s3 branch from b93d0f7 to 22e1174 Dec 6, 2018

@RafiZz RafiZz closed this Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.