New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 ir attachment s3 mini images #678

Merged
merged 3 commits into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@yelizariev
Member

yelizariev commented Nov 8, 2018

No description provided.

@Ramil-Mukhametzyanov

The main goal is achieved, but there are new errors:

  1. Fail to replace product image uploading the new image
  2. Error 'Incorrect padding' appears when trying to convert product image to an image via link
  3. If the newly created image is set through the URL, the image is not displayed.
@yelizariev

This comment has been minimized.

Member

yelizariev commented Nov 12, 2018

  1. it's browser cache problem. Try the same scenario without module
  2. What do you mean? White Border of the image? Try the same scenario without module
  3. Clarify steps to reproduce please
@Ramil-Mukhametzyanov

This comment has been minimized.

Member

Ramil-Mukhametzyanov commented Nov 12, 2018

1. it's browser cache problem. Try the same scenario without module

If I try to change the product image by following the steps below, changing the image will fail:
Edit product->Click upload 📁 button ->Select image->Click Save.
I need to delete the image and save the product, then upload new image to succeed.
Ok, this is not a bug.

@Ramil-Mukhametzyanov

This comment has been minimized.

Member

Ramil-Mukhametzyanov commented Nov 12, 2018

2. What do you mean? White Border of the image? Try the same scenario without module
3. Clarify steps to reproduce please

The same issue is being fixed here:
#674
We need to create another pull-requests to repair ir_attachment_url for Odoo 10.0 and 11.0.

@Ramil-Mukhametzyanov

Finally, there are no related issues.

yelizariev added some commits Nov 8, 2018

@yelizariev yelizariev merged commit 5eec8b9 into it-projects-llc:10.0 Nov 14, 2018

1 of 2 checks passed

ci/runbot runbot build 23889-678-434976
Details
Hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment