New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 bc375d9170a5576eee8e81d10c2ed980c3541b13 #686

Merged
merged 8 commits into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@Rusllan
Contributor

Rusllan commented Nov 21, 2018

No description provided.

yelizariev and others added some commits Nov 8, 2018

📖 IAM has to be under Installation section
Because it's something that can be done before the module installation
🚑 when the "image_resize_image" function was called, they received th…
…e error "binascii.Error: decoding with base64 codec failed (Error: Incorrect padding)", since the value of the binary field is the URL, not the base_64 string
@@ -79,7 +109,8 @@ def binary_content(cls, xmlid=None, model='ir.attachment', id=None, field='datas
if module_resource_path.startswith(module_path):
with open(module_resource_path, 'rb') as f:
content = base64.b64encode(f.read())
last_update = pycompat.text_type(os.path.getmtime(module_resource_path))
# commented out because the variable is not used and a lint error occurs

This comment has been minimized.

@hound

hound bot Nov 21, 2018

trailing whitespace

`1.2.0`
-------
- **Improvement:** Save resized image to s3 instead of passing original (big) image

This comment has been minimized.

@yelizariev

yelizariev Nov 23, 2018

Member

New update to test

`1.1.7`
-------
- **Fix:** Product Variant were downloaded on server instead of passing url

This comment has been minimized.

@yelizariev

yelizariev Nov 23, 2018

Member

New update to test

@Ramil-Mukhametzyanov
  1. Open Website>Configuration>Settings
  2. Set Product Catalog>Attributes and Variants
  3. Go to Catalog>Product Variants
  4. Choose and click edit a product.
  5. Change the product image using a link
    Result:
    binascii.Error: decoding with 'base64' codec failed (Error: Incorrect padding)

@RafiZz RafiZz force-pushed the Rusllan:11.0-bc375d9170a5576eee8e81d10c2ed980c3541b13 branch from 7be421b to 3e1a737 Dec 4, 2018

@yelizariev yelizariev merged commit 27e5052 into it-projects-llc:11.0 Dec 5, 2018

3 checks passed

Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 25164-686-3e1a73 (runtime 389s)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment