New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX requires which is changed in odoo 11 #690

Open
wants to merge 1 commit into
base: 11.0
from

Conversation

Projects
None yet
2 participants
@KomarovAlea

KomarovAlea commented Nov 29, 2018

Old code was wrong and take error. Look at you browser console when you load odoo 11.
I fixed this code and tested it. New code is work fine.

FIX requires which is changed in odoo 11
Old code was wrong and take error. Look at you browser console when you load odoo 11.
I fixed this code and tested it. New code is work fine.

@yelizariev yelizariev requested a review from KolushovAlexandr Nov 30, 2018

@KolushovAlexandr

This comment has been minimized.

Member

KolushovAlexandr commented Dec 4, 2018

Hi @KomarovAlea Thanks for contributing, but this module isn't even installable https://github.com/it-projects-llc/misc-addons/blob/11.0/web_polymorphic_field/__openerp__.py#L31. I've checked your changes with product_details and caught a bug. In all our modules that depend on the web_polymorphic_field, we refused from that dependency now. @yelizariev PR may be closed.

@KomarovAlea

This comment has been minimized.

KomarovAlea commented Dec 4, 2018

I've checked your changes with product_details and caught a bug.

I checked new code and it's worked. What error did you find in my code?
I get a Project with modules which depends from web_polymirphic_field and I have to continue support them. If my code contain bug then I have to fixed them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment