New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 fix ir attachment url getting mimetype #699

Merged
merged 3 commits into from Dec 18, 2018

Conversation

Projects
None yet
2 participants
@RafiZz
Copy link
Member

RafiZz commented Dec 11, 2018

No description provided.

@yelizariev
Copy link
Member

yelizariev left a comment

Also, add updating version and add changelog into the first commit

@RafiZz RafiZz force-pushed the RafiZz:10.0-fix-ir_attachment_url-getting_mimetype branch from 2e46c2a to 8b36344 Dec 12, 2018

`1.1.7`
-------

- **Fix** When a link to a picture that does not have an extension is written in a binary field, its mimetype is not determined, which leads to an "binascii.Error: decoding with base64 codec failed (Error: Incorrect padding)"

This comment has been minimized.

@yelizariev
Show resolved Hide resolved ir_attachment_url/models/binary_fields.py Outdated

@RafiZz RafiZz force-pushed the RafiZz:10.0-fix-ir_attachment_url-getting_mimetype branch from 8b36344 to 13c58f7 Dec 13, 2018

Show resolved Hide resolved ir_attachment_url/models/binary_fields.py Outdated

RafiZz added some commits Dec 11, 2018

@RafiZz RafiZz force-pushed the RafiZz:10.0-fix-ir_attachment_url-getting_mimetype branch from 13c58f7 to f2097c1 Dec 14, 2018

@yelizariev yelizariev merged commit 5abeb01 into it-projects-llc:10.0 Dec 18, 2018

5 of 6 checks passed

coverage/coveralls Coverage decreased (-0.3%) to 66.029%
Details
Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 25890-699-fb11d5 (runtime 599s)
Details
codecov/patch/backend Coverage not affected when comparing 3fcd192...fb11d5f
Details
codecov/patch/tests Coverage not affected when comparing 3fcd192...fb11d5f
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment