New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] ir_attachment modules #714

Open
wants to merge 4 commits into
base: 10.0
from

Conversation

Projects
None yet
2 participants
@RafiZz
Copy link
Member

RafiZz commented Dec 29, 2018

No description provided.

* You can also set these parameters using environment variables

Mapping Environment variables to Odoo System parameters:
* ``S3_BUCKET``: it is ``s3.bucket`` parameter

This comment has been minimized.

@yelizariev

yelizariev Dec 29, 2018

Member

add extra empty line

image

This comment has been minimized.

@RafiZz

RafiZz Jan 9, 2019

Member

Done.

* ``S3_ACCESS_KEY_ID``: it is ``s3.access_key_id`` parameter
* ``S3_SECRET_KEY``: it is ``s3.secret_key`` parameter

NOTE: if you simultaneously set parameters both in the Environment variables and in the Odoo System parameters, then the Odoo System parameters have the highest priority.

This comment has been minimized.

@yelizariev
@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Dec 29, 2018

There is no :fix: emoji 😢

@@ -37,9 +37,6 @@ def _get_s3_settings(self, param_name, os_var_name):
res = config_obj.sudo().get_param(param_name)
if not res:
res = os.environ.get(os_var_name)
if res:
config_obj.sudo().set_param(param_name, res)
_logger.info('parameter {} has been created from env {}'.format(param_name, os_var_name))

This comment has been minimized.

@yelizariev

yelizariev Dec 29, 2018

Member

Update changelog for this

This comment has been minimized.

@RafiZz

RafiZz Jan 9, 2019

Member

Done.

RafiZz added some commits Dec 18, 2018

@RafiZz RafiZz force-pushed the RafiZz:10.0-imp-ir_attachment_modules branch from 017215d to 41d6f6c Jan 9, 2019

@yelizariev
Copy link
Member

yelizariev left a comment

Code is fine

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Jan 11, 2019

Tests are not passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment