Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 autostaging base port #729

Merged
merged 3 commits into from Mar 22, 2019

Conversation

Projects
None yet
6 participants
@Ommo73
Copy link
Member

Ommo73 commented Feb 11, 2019

No description provided.

@TestMergeBot
Copy link

TestMergeBot left a comment

Some features needs to be tested

`1.0.0`
-------

- Init version

This comment has been minimized.

@TestMergeBot

TestMergeBot Feb 11, 2019

Someone has to test it

Show resolved Hide resolved autostaging_base/README.rst Outdated
Show resolved Hide resolved autostaging_base/README.rst Outdated
Show resolved Hide resolved autostaging_project_task/__manifest__.py Outdated
Show resolved Hide resolved autostaging_base/__manifest__.py Outdated
@Ramil-Mukhametzyanov
Copy link
Member

Ramil-Mukhametzyanov left a comment

Autostaging moves a task to a stage that is not in the project
Steps to reproduce :

  1. Select two projects
  • I chose "E-Learning Intergation" and "Research&Development"
  1. Create a stage for one of the projects.
  • I created a "Learned" stage for the "E-Learning Intergation" project
  1. Create a stage for both projects.
  • I created a stage "Study"
  1. Set the autostaging from the second stage to the first stage
  • Enable autostaging for "Study" , the next stage "Learned"
  1. Create a tasks in projects in the "Study" stage
  • "Research 1" task in the "Research and Development" project
    Result: After the autostaging, the task stage will be changed to a stage that does not exist in the project.
  • Task "Research 1" in the "Learned" stage
    study
    learned
@Ramil-Mukhametzyanov
Copy link
Member

Ramil-Mukhametzyanov left a comment

@Ommo73
not allow to save changes of autostaging settings if the next stage does not exist in one or more projects of edited stage.

@Ramil-Mukhametzyanov
Copy link
Member

Ramil-Mukhametzyanov left a comment

We do not have to improve the module in this PR.

@yelizariev
Copy link
Member

yelizariev left a comment

Add yourself to copyright lines and contributors list. Cleanup commits

@Ommo73 Ommo73 force-pushed the Ommo73:11.0-autostaging_base_port branch from 6dd8476 to 6502ef9 Mar 5, 2019

@yelizariev
Copy link
Member

yelizariev left a comment

Code update in base_attendance is fine

Show resolved Hide resolved base_attendance/doc/changelog.rst Outdated
@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Mar 12, 2019

@Ommo73 you don't really need to put work "Port" in commit message as you have commit tags about it. Or at least don't use asterisks
⬆️1️⃣1️⃣ port autostaging_base
or
⬆️1️⃣1️⃣ autostaging_base

@yelizariev
Copy link
Member

yelizariev left a comment

Clean up commits. It must be just 3 commits

arrow_uponeone autostaging_project_task Port

arrow_uponeone autostaging_base Port

ambulance incorrect attribute name

Ommo73 and others added some commits Feb 11, 2019

@Ommo73 Ommo73 force-pushed the Ommo73:11.0-autostaging_base_port branch from 916288e to 45a2349 Mar 21, 2019

@ilmir-k ilmir-k merged commit 16f73cd into it-projects-llc:11.0 Mar 22, 2019

5 of 6 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 68.647%
Details
Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 30619-729-45a234 (runtime 1093s)
Details
codecov/patch/backend Coverage not affected when comparing 8921d1e...45a2349
Details
codecov/patch/tests Coverage not affected when comparing 8921d1e...45a2349
Details
@KolushovAlexandr

This comment has been minimized.

Copy link
Member

KolushovAlexandr commented Mar 22, 2019

😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.