Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up::one::one: res_partner_skype Port #736

Open
wants to merge 2 commits into
base: 11.0
from

Conversation

Projects
None yet
2 participants
@Ommo73
Copy link
Member

Ommo73 commented Apr 11, 2019

No description provided.

_renderReadonly: function() {
this.$el.text(this.value)
.addClass('o_form_uri o_text_overflow')
.attr('href', this.prefix + ':' + this.value + '?'+ 'call');

This comment has been minimized.

Copy link
@hound

hound bot Apr 11, 2019

Unexpected string concatenation of literals no-useless-concat

},

getFocusableElement: function () {
return this.mode === 'readonly' ? this.$el : this._super.apply(this, arguments);

This comment has been minimized.

Copy link
@hound

hound bot Apr 11, 2019

Expected newline between consequent and alternate of ternary expression multiline-ternary
Expected newline between test and consequent of ternary expression multiline-ternary

this._super.apply(this, arguments);
this.clickable = true;
this.tagName = this.mode === 'readonly' ? 'a' : 'input';

This comment has been minimized.

Copy link
@hound

hound bot Apr 11, 2019

Expected newline between consequent and alternate of ternary expression multiline-ternary
Expected newline between test and consequent of ternary expression multiline-ternary

_renderReadonly: function() {
this.$el.text(this.value)
.addClass('o_form_uri o_text_overflow')
.attr('href', this.prefix + ':' + this.value + '?'+ 'call');

This comment has been minimized.

Copy link
@hound

hound bot Apr 17, 2019

Unexpected string concatenation of literals no-useless-concat

@Ommo73 Ommo73 force-pushed the Ommo73:11.0-res_partner_skype_port branch from ccd4806 to 0d1d6c4 Apr 17, 2019

Ommo73 added some commits Apr 11, 2019

@Ommo73 Ommo73 force-pushed the Ommo73:11.0-res_partner_skype_port branch from 0d1d6c4 to 77e923f Apr 18, 2019

"name": "Skype field in partner form",
"version": "1.0.1",
"name": """Skype field in partner form""",
"summary": """Send private messages to specified recipients, regardless of who are in followers list.""",

This comment has been minimized.

Copy link
@KolushovAlexandr
<templates>
<t t-name="FieldSkype" t-extend="FieldEmail">
<t t-name="FieldSkype" t-extend="FieldReference">

This comment has been minimized.

Copy link
@KolushovAlexandr

KolushovAlexandr Apr 18, 2019

Member

Why here is reference field, but in js you extend mail one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.