Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 ir attachment url ecommerce #749

Open

Conversation

Projects
None yet
4 participants
@GabbasovDinar
Copy link
Member

commented May 24, 2019

related with #714

RafiZz and others added some commits Dec 17, 2018

encoding='base64', filetype='PNG')
elif attach.res_field == 'image_small':
value = tools.image_resize_image(base64_source=attach.datas, size=(64, 64),
encoding='base64', filetype='PNG')

This comment has been minimized.

Copy link
@hound

hound bot May 24, 2019

continuation line over-indented for visual indent

@@ -97,16 +107,24 @@ def _inverse_datas(self):
for attach in self & s3_records: # datas field has got empty somehow in the result of ``s3_records = self.sudo().search([('id', 'in', self.ids)] + condition)`` search for non-superusers but it is in original recordset. Here we use original (with datas) in case it intersects with the search result
resized_to_remove |= attach.sudo().resized_ids
value = attach.datas
if attach.res_field == 'image_medium':
value = tools.image_resize_image(base64_source=attach.datas, size=(128, 128),
encoding='base64', filetype='PNG')

This comment has been minimized.

Copy link
@hound

hound bot May 24, 2019

continuation line over-indented for visual indent

@GabbasovDinar GabbasovDinar reopened this May 24, 2019

@GabbasovDinar GabbasovDinar changed the base branch from 12.0 to 10.0 May 24, 2019

@yelizariev

This comment has been minimized.

Copy link
Member

commented May 30, 2019

This branch has conflicts that must be resolved
Use the web editor or the to resolve conflicts.
Conflicting files
.travis.yml

@Ramil-Mukhametzyanov
Copy link
Member

left a comment

Before a S3 credentials are entered, after the ir_attachment_s3 module is installed, the product images loaded via the link will be lost in the Shop product list page. Even after S3 credentials are entered, they will not be resized in backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.