Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web_debranding): no more bytes returned #777

Open
wants to merge 1 commit into
base: 11.0
from

Conversation

Projects
None yet
2 participants
@blaggacao
Copy link

commented Jul 10, 2019

Closes #762
Replaces #719

@ilmir-k ilmir-k requested a review from KolushovAlexandr Jul 10, 2019

@blaggacao

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

Break... this is not the solution
from: https://docs.python.org/3.5/library/xml.etree.elementtree.html

Generates a string representation of an XML element, including all subelements. element is an Element instance. encoding [1] is the output encoding (default is US-ASCII). Use encoding="unicode" to generate a Unicode string (otherwise, a bytestring is generated). method is either "xml", "html" or "text" (default is "xml"). short_empty_elements has the same meaning as in ElementTree.write(). Returns an (optionally) encoded string containing the XML data.
@blaggacao

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

Ok, this is the correct solution, but it exposes an underlying odoo bug, which I will solve in a second... please help accepting.

@yelizariev
Copy link
Member

left a comment

Should be ok if it works :)

@blaggacao

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

Here is the PR: odoo/odoo#34751
The commit: odoo/odoo@5a8c31a

@blaggacao

This comment has been minimized.

@blaggacao

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

CI Failure due to upstream patch not applied...

@yelizariev
Copy link
Member

left a comment

I need to block this:

  • The PR has to be merged
  • We need to update documentation to say that it works for latest version only or with the patch applied

I'd prefer to merge this in odoo 13 instead where all users have the patch for sure

@blaggacao

This comment has been minimized.

Copy link
Author

commented Jul 10, 2019

Okk, I assume odoo might merge the fix and forward port the patch... I hope... You could upvote...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.