Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up::one::two:, pos_keyboard: #1059

Merged
merged 4 commits into from Aug 23, 2019

Conversation

@fedoranvar
Copy link
Contributor

commented Jul 25, 2019

Refactoring

pos_keyboard/__manifest__.py Outdated Show resolved Hide resolved
pos_keyboard/doc/changelog.rst Outdated Show resolved Hide resolved
pos_keyboard/README.rst Outdated Show resolved Hide resolved

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch 3 times, most recently from bbb4ded to 1815386 Jul 25, 2019

@KolushovAlexandr
Copy link
Member

left a comment

@fedoranvar When I click number keys in the password popup they are added doubled

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch from 7cadbf1 to 92204f9 Jul 25, 2019

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch 2 times, most recently from 2727d9c to 335ac65 Jul 29, 2019

@Ramil-Mukhametzyanov
Copy link
Member

left a comment

There is reference to Odoo 10.0 in the static/description/index.html file.

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch from 335ac65 to 9e004b3 Aug 12, 2019

@@ -62,7 +62,7 @@ <h2>Need our service?</h2>
-o-transform: rotate(8deg);
-moz-transform: rotate(8deg);
-ms-transform: rotate(8deg);">
Tested on Odoo<br/>10.0 community
Tested on Odoo<br/>11.0 community

This comment has been minimized.

Copy link
@Ramil-Mukhametzyanov

Ramil-Mukhametzyanov Aug 12, 2019

Member

@fedoranvar Porting to Odoo 12.0

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch from 9e004b3 to 31d9251 Aug 12, 2019

@em230418
Copy link
Member

left a comment

Scenario:

  • login as demo
  • Point of Sale -> New session
  • Click on any item in shop
  • Click on "Payment"
  • Typing in usual keyboard, for example 987, nothing appears. Expecting something to be appeared.
  • Clicking on any button in virtual keyboard. For example 1. Finally something appears with previous "987".
@fedoranvar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Scenario:

  • login as demo
  • Point of Sale -> New session
  • Click on any item in shop
  • Click on "Payment"
  • Typing in usual keyboard, for example 987, nothing appears. Expecting something to be appeared.
  • Clicking on any button in virtual keyboard. For example 1. Finally something appears with previous "987".

Эта проблема работы Оду, не работы этого модуля.
проверялось на ранботе оду.

@em230418

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Давай заодно и это с тестами: b30d0a5

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch 7 times, most recently from 1aaa0ef to e979f1f Aug 19, 2019

@@ -57,13 +62,26 @@ odoo.define('pos_keyboard.tour', function (require) {
}];
}

function connect_disconnect_keyboard() {
if (odoo._modules.indexOf('pos_cashier_select') !== -1) {

This comment has been minimized.

Copy link
@hound

hound bot Aug 22, 2019

Empty block statement no-empty

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch from e979f1f to 4d25f4d Aug 22, 2019

content: 'Close Payment-Screen',
trigger: '.button:contains(Back)',
}]);
return stps

This comment has been minimized.

Copy link
@hound

hound bot Aug 22, 2019

Missing semicolon.

@@ -57,13 +62,36 @@ odoo.define('pos_keyboard.tour', function (require) {
}];
}

function cashier_select() {
return

This comment has been minimized.

Copy link
@hound

hound bot Aug 22, 2019

Missing semicolon.

content: 'Close Payment-Screen',
trigger: '.button:contains(Back)',
}]);
return stps

This comment has been minimized.

Copy link
@hound

hound bot Aug 22, 2019

Missing semicolon semi

@@ -57,13 +62,36 @@ odoo.define('pos_keyboard.tour', function (require) {
}];
}

function cashier_select() {
return

This comment has been minimized.

Copy link
@hound

hound bot Aug 22, 2019

Missing semicolon semi

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch 4 times, most recently from 9a8d361 to f6f03a6 Aug 22, 2019

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-pos_keyboard-port branch from f6f03a6 to 597ac9d Aug 22, 2019

@em230418

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

I approve to merge it now

@itpp-bot itpp-bot merged commit 18cb182 into it-projects-llc:12.0 Aug 23, 2019

3 of 4 checks passed

Travis CI - Pull Request Build Failed
Details
Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 03976-1059-597ac9 (runtime 381s)
Details
@itpp-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Approved by @em230418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.