Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 pos menu port #1065

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@fedoranvar
Copy link
Contributor

commented Jul 30, 2019

No description provided.

@Ramil-Mukhametzyanov
Copy link
Member

left a comment

There is no Available Product Sets option in POS settings.

@fedoranvar fedoranvar force-pushed the fedoranvar:11.0-pos_menu-port branch 2 times, most recently from cbd42b0 to a192959 Jul 31, 2019

@fedoranvar fedoranvar force-pushed the fedoranvar:11.0-pos_menu-port branch from a192959 to e99c6ea Jul 31, 2019

@em230418
Copy link
Member

left a comment

Everything works fine. Nonessential changes required in README.rst


Usage instructions: `<doc/index.rst>`_

Changelog: `<doc/changelog.rst>`_

Tested on Odoo 10.0 0351677a00df8bd76fa207a38dc2ecdefdc6940a
Tested on Odoo 11.0 0351677a00df8bd76fa207a38dc2ecdefdc6940a

This comment has been minimized.

Copy link
@em230418

em230418 Aug 7, 2019

Member

This commit is from 12.0 branch
odoo/odoo@0351677

This comment has been minimized.

Copy link
@fedoranvar

fedoranvar Aug 7, 2019

Author Contributor

changed commit

@@ -9,7 +9,8 @@ Credits

Contributors
------------
* `Dinar Gabbasov <https://it-projects.info/team/GabbasovDinar>`__
* `Gabbasov Dinar <https://it-projects.info/team/GabbasovDinar>`_

This comment has been minimized.

Copy link
@em230418

em230418 Aug 7, 2019

Member

We don't need to change two underscores to one

This comment has been minimized.

Copy link
@fedoranvar

fedoranvar Aug 7, 2019

Author Contributor

checked

@fedoranvar fedoranvar force-pushed the fedoranvar:11.0-pos_menu-port branch 2 times, most recently from d4d06bf to 2a5cb89 Aug 7, 2019


Usage instructions: `<doc/index.rst>`_

Changelog: `<doc/changelog.rst>`_

Tested on Odoo 10.0 0351677a00df8bd76fa207a38dc2ecdefdc6940a
Tested on Odoo 11.0 e99c6ea835c119b478c853f7b6af511afe453c47

This comment has been minimized.

Copy link
@em230418

em230418 Aug 7, 2019

Member

Commit does not exist: odoo/odoo@e99c6ea

This comment has been minimized.

Copy link
@fedoranvar

fedoranvar Aug 8, 2019

Author Contributor

how to insert id of commit?

I'm doing 'git log -1'
putting in readme
git add . && git commit --amend

Am I right?

This comment has been minimized.

Copy link
@em230418

em230418 Aug 8, 2019

Member

Don't know. I do like this:

https://github.com/odoo/odoo/tree/11.0
Ctrl+F "Latest commit"
Copy hyperlink to the right
You will get
https://github.com/odoo/odoo/commit/<COMMIT_ID>

This comment has been minimized.

Copy link
@fedoranvar

fedoranvar Aug 8, 2019

Author Contributor

oh, I think I get it

So we paste commit-id of odoo, not the module

This comment has been minimized.

Copy link
@GabbasovDinar

GabbasovDinar Aug 8, 2019

Member

git rev-parse HEAD

@fedoranvar fedoranvar force-pushed the fedoranvar:11.0-pos_menu-port branch from 2a5cb89 to b49a06c Aug 8, 2019

@fedoranvar fedoranvar force-pushed the fedoranvar:11.0-pos_menu-port branch from b49a06c to b6fff52 Aug 8, 2019

@yelizariev

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

I approve to merge it now

@itpp-bot itpp-bot merged commit 1006fc3 into it-projects-llc:11.0 Aug 9, 2019

3 of 4 checks passed

Travis CI - Pull Request Build Failed
Details
Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 03035-1065-b6fff5 (runtime 394s)
Details
@itpp-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Approved by @yelizariev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.