Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:ambulance: Added event handler for numpad-click; #1082

Open
wants to merge 1 commit into
base: 10.0
from

Conversation

@fedoranvar
Copy link
Contributor

commented Aug 15, 2019

No description provided.

@em230418
Copy link
Member

left a comment

Демо юзер не может создать сессию.

Вроде можно, не? Та-же функция, где мы делаем sudo, вызывает другую функцию которая пытается создать объект ir.sequence без sudo.

Sorry, you are not allowed to create this kind of document. Only users with the following access level are currently allowed to do that:

  • Administration/Settings

(Document model: ir.sequence) - (Operation: create, User: 5)

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_journal_pin-ambulance branch from 9b286b8 to f8f264d Aug 23, 2019

@@ -39,7 +40,7 @@ def init_pin_journal(self):
if pin_journal_active:
return

pin_journal = self._create_pin_journal(dict(
pin_journal = self.sudo()_create_pin_journal(dict(

This comment has been minimized.

Copy link
@hound

hound bot Aug 23, 2019

SyntaxError: invalid syntax

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_journal_pin-ambulance branch from f8f264d to 85e1ae4 Aug 26, 2019

@kaadevelop
Copy link
Member

left a comment

1 modules is updated:

Updated files in 1 installable modules:

└─ pos_journal_pin/
   ├─ README.rst
   ├─ __manifest__.py
   ├─ doc/
   |  ├─ changelog.rst
   |  └─ index.rst
   ├─ models/
   |  └─ models.py
   └─ static/
      └─ src/
         └─ js/
            └─ main.js

Updated files in 0 non-installable modules:
are absent

You can use this review-bot too. Look: https://odoo-devops.readthedocs.io/en/latest/


- **Fix:** Adding first payment line by clicking numpad button, without asking manager's PIN, if first payment method in list require manager's PIN
- **Fix:** Creating sessions by non-administrators

This comment has been minimized.

Copy link
@kaadevelop

kaadevelop Aug 26, 2019

Member

Has to be tested

@fedoranvar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Демо юзер не может создать сессию.

Вроде можно, не? Та-же функция, где мы делаем sudo, вызывает другую функцию которая пытается создать объект ir.sequence без sudo.

Sorry, you are not allowed to create this kind of document. Only users with the following access level are currently allowed to do that:

  • Administration/Settings

(Document model: ir.sequence) - (Operation: create, User: 5)

исправлено

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_journal_pin-ambulance branch from 85e1ae4 to f3284cd Sep 2, 2019

@kaadevelop
Copy link
Member

left a comment

1 installable module is updated:

└─ pos_journal_pin/
   ├─ README.rst
   ├─ __manifest__.py
   ├─ doc/
   |  ├─ changelog.rst
   |  └─ index.rst
   ├─ models/
   |  └─ models.py
   ├─ static/
   |  └─ src/
   |     └─ js/
   |        └─ main.js
   └─ tests/
      └─ test_journal_pin.py

Not installable modules remain unchanged.

sent by ✌️ Review Bot


- **Fix:** Adding first payment line by clicking numpad button, without asking manager's PIN, if first payment method in list require manager's PIN
- **Fix:** Creating sessions by non-administrators

This comment has been minimized.

Copy link
@kaadevelop

kaadevelop Sep 2, 2019

Member

Has to be tested

@em230418

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Не проходят тесты и в тревисе и из под одуап.
pos1082.log

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_journal_pin-ambulance branch from f3284cd to 4b98f5d Sep 6, 2019

@itpp-bot
Copy link
Contributor

left a comment

1 installable module is updated:

└─ pos_journal_pin/
   ├─ README.rst
   ├─ __manifest__.py
   ├─ doc/
   |  ├─ changelog.rst
   |  └─ index.rst
   ├─ models/
   |  └─ models.py
   ├─ static/
   |  └─ src/
   |     └─ js/
   |        └─ main.js
   └─ tests/
      └─ test_journal_pin.py

Not installable modules remain unchanged.

sent by ✌️ Odoo Review Bot


- **Fix:** Adding first payment line by clicking numpad button, without asking manager's PIN, if first payment method in list require manager's PIN
- **Fix:** Creating sessions by non-administrators

This comment has been minimized.

Copy link
@itpp-bot

itpp-bot Sep 6, 2019

Contributor

Has to be tested

main("admin")

def test_02_pos_journal_pin(self):
main("demo")

This comment has been minimized.

Copy link
@hound

hound bot Sep 6, 2019

undefined name 'main'

timeout=100,
)

def test_01_pos_journal_pin(self):
main("admin")

This comment has been minimized.

Copy link
@hound

hound bot Sep 6, 2019

undefined name 'main'

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_journal_pin-ambulance branch from 4b98f5d to c5d0510 Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.