Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:ambulance: Function 'disconnect' not working in expected way #1084

Closed

Conversation

@fedoranvar
Copy link
Contributor

commented Aug 15, 2019

No description provided.

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_keyboard-ambulance branch 2 times, most recently from 8914199 to a5af46f Aug 16, 2019

content: 'Scan product by reference code',
trigger: '.pos-branding',
run: function () {
posmodel.barcode_reader.scan(refcode);

This comment has been minimized.

Copy link
@hound

hound bot Aug 16, 2019

'posmodel' is not defined no-undef

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_keyboard-ambulance branch from a5af46f to b30d0a5 Aug 16, 2019

@em230418
Copy link
Member

left a comment

Напиши тест-кейс, который решает это исправление.
Можно отдельным коммитом.

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_keyboard-ambulance branch from 811747f to 6cd2139 Aug 19, 2019

@em230418
Copy link
Member

left a comment

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_keyboard-ambulance branch 2 times, most recently from ce53914 to 6a23ebb Aug 20, 2019


if (odoo._modules.indexOf('pos_cashier_select') !== -1) {
stps = stps.concat([{
trigger: '.modal-dialog.cashier .selection-item:contains("Mitchell Admin")',

This comment has been minimized.

Copy link
@em230418

em230418 Aug 22, 2019

Member

Предлагаю поменять на "Admin", потому-что скушает "Mitchell Admin" и скушает это:
FireShot Capture 17 - Odoo POS

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_keyboard-ambulance branch from 6a23ebb to a92e261 Aug 22, 2019

@em230418

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Merged 78dcfa2

@em230418 em230418 closed this Aug 23, 2019

KolushovAlexandr pushed a commit to KolushovAlexandr/pos-addons that referenced this pull request Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.