Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:shield: pos_menu: updated tests #1085

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@fedoranvar
Copy link
Contributor

commented Aug 15, 2019

No description provided.

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_menu-shield branch from 43cc18b to d3a552a Aug 16, 2019

}, {
trigger: ".o_pos_kanban .o_kanban_record:not(:first) button.oe_kanban_action_button",
}, {
trigger: ".o_kanban_record:contains("+ "Shop1" +") .btn-primary:first",

This comment has been minimized.

Copy link
@hound

hound bot Aug 16, 2019

Unexpected string concatenation of literals no-useless-concat

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_menu-shield branch from d3a552a to 1b276d9 Aug 16, 2019


var steps = [];
var menu = ["Boni Oranges", "Black Grapes", "Carrots", "Conference pears"];
var pos = "Shop1"

This comment has been minimized.

Copy link
@hound

hound bot Aug 16, 2019

Missing semicolon.


var steps = [];
var menu = ["Boni Oranges", "Black Grapes", "Carrots", "Conference pears"];
var pos = "Shop1"

This comment has been minimized.

Copy link
@hound

hound bot Aug 16, 2019

Missing semicolon semi

}, {
trigger: ".o_pos_kanban .o_kanban_record:not(:first) button.oe_kanban_action_button",
}, {
trigger: ".o_kanban_record:contains("+ pos +") .btn-primary:first",

This comment has been minimized.

Copy link
@hound

hound bot Aug 16, 2019

'pos' was used before it was defined no-use-before-define

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_menu-shield branch 2 times, most recently from 985358c to ba95d53 Aug 16, 2019

position: "top"
}]);

function pos_closing(){

This comment has been minimized.

Copy link
@KolushovAlexandr

KolushovAlexandr Aug 19, 2019

Member

not necessary, it does not check anything related to the module's functionality. Just takes time

@fedoranvar fedoranvar force-pushed the fedoranvar:10.0-pos_menu-shield branch from ba95d53 to 5ec0844 Aug 19, 2019

@kaadevelop
Copy link
Member

left a comment

1 installable module is updated:

└─ pos_menu/
   ├─ static/
   |  └─ src/
   |     └─ js/
   |        └─ tour.js
   └─ tests/
      ├─ __init__.py
      └─ test_default.py

Not installable modules remain unchanged.

No new features in doc/changelog.rst files of installable modules

sent by ✌️ Review Bot

@em230418

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Оказывается odoo не принимает тесты, если имя модуля, в котором тест объявлен, не начинается на "test_". Доказательство. Поскольку сам выяснил, сам же закоммитил.

Приму после проверки тревиса.

@em230418

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

I approve to merge it now

@itpp-bot itpp-bot merged commit c05fbca into it-projects-llc:10.0 Sep 2, 2019

6 of 8 checks passed

Travis CI - Pull Request Build Created
Details
Travis CI - Pull Request Build Created
Details
Hound No violations found. Woof!
Travis CI - Pull Request Build Passed
Details
ci/branches Branch names are correct
Details
ci/runbot runbot build 04259-1085-d9863e (runtime 442s)
Details
codecov/patch/backend Coverage not affected when comparing 8404730...d9863e5
Details
codecov/patch/tests Coverage not affected when comparing 8404730...d9863e5
Details
@itpp-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Approved by @em230418

sent by 👷 Merge Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.