Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 pos mobile fix clientlist #1087

Merged

Conversation

@em230418
Copy link
Member

commented Aug 21, 2019

Reason is that $('.pos.mobile .window').css({display: 'table'}) from change_screen_type was not setting style for all elements in selector due to some bug in jquery 1.11.1. But somehow
$('.pos.mobile .window').css({display: 'none'}) is working correct, so it works correctly without this css rule.

🚑 pos_mobile: fixed bug, where customers were not shown
Reason is that $('.pos.mobile .window').css({display: 'table'})
from change_screen_type was not setting style for all elements in
selector due to some bug in jquery 1.11.1. But somehow
$('.pos.mobile .window').css({display: 'none'}) is working correct,
so it works correctly without this css rule.
pos_mobile/static/src/js/tour.js Outdated Show resolved Hide resolved
pos_mobile/static/src/js/tour.js Outdated Show resolved Hide resolved

@em230418 em230418 force-pushed the em230418:12.0-pos_mobile-fix-clientlist branch from ba891bf to 99c2c06 Aug 21, 2019

@Ramil-Mukhametzyanov
Copy link
Member

left a comment

There is no vertical scrolling in the customer list screen.

@em230418 em230418 force-pushed the em230418:12.0-pos_mobile-fix-clientlist branch from e6af7e3 to c5b0a64 Aug 22, 2019

@em230418

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

I approve to merge it now

@itpp-bot itpp-bot merged commit 9f15daf into it-projects-llc:12.0 Aug 22, 2019

4 checks passed

Hound No violations found. Woof!
Travis CI - Pull Request Build Passed
Details
ci/branches Branch names are correct
Details
ci/runbot runbot build 03952-1087-c5b0a6 (runtime 311s)
Details
@itpp-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Approved by @em230418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.