New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 pos debt notebook port #557

Merged
merged 11 commits into from Jan 22, 2018

Conversation

Projects
None yet
4 participants
@KolushovAlexandr
Copy link
Member

KolushovAlexandr commented Jan 15, 2018

No description provided.

@@ -1,16 +1,16 @@
# -*- coding: utf-8 -*-

This comment has been minimized.

@yelizariev

yelizariev Jan 18, 2018

Member

Fix empty lines

('debt', 'Display Debt'),
('credit', 'Display Credit')
], default='debt', string='Debt Type', help='Way to display debt value (label and sign of the amount). '
'In both cases debt will be red, credit - green')

This comment has been minimized.

@yelizariev

yelizariev Jan 18, 2018

Member

This setting is used in partner form, so it has to be global and not per POS

This comment has been minimized.

@KolushovAlexandr

KolushovAlexandr Jan 18, 2018

Member

@yelizariev in odoo 11.0 model pos.config.settings is included in pos.config, so i made the same changes. Where should they be then?

This comment has been minimized.

@KolushovAlexandr

KolushovAlexandr Jan 18, 2018

Member

@yelizariev on the partner form it works correctly, but the partner form is reachable now only after installing account_invoicing, because the debendent module account is "Core mechanisms for the accounting modules. To display the menuitems, install the module account_invoicing."

This comment has been minimized.

@yelizariev

yelizariev Jan 18, 2018

Member

Use res.config.settings for settings
Install module contacts to get partner views

KolushovAlexandr added some commits Jan 18, 2018

@ilmir-k ilmir-k requested a review from Railia Jan 19, 2018

@Railia

Railia approved these changes Jan 19, 2018

@ilmir-k

This comment has been minimized.

Copy link
Member

ilmir-k commented Jan 19, 2018

@yelizariev functional part has been reviewed, review the code please

@yelizariev yelizariev merged commit f5bd36a into it-projects-llc:11.0 Jan 22, 2018

3 of 4 checks passed

coverage/coveralls Coverage decreased (-13.4%) to 74.723%
Details
ci/branches Branch names are correct
Details
ci/runbot runbot build 12939-557-c1739b (runtime 595s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ilmir-k added a commit to ilmir-k/pos-addons that referenced this pull request Aug 7, 2018

[11.0][PORT] pos_invoice_pay to 11.0 (it-projects-llc/addons-dev#365)
* [11.0][PORT] pos_invoice_pay to 11.0

* [11.0][PORT] pos debt notebook port (it-projects-llc#557)

* [DOC] pos_order_note: new price and demo url (it-projects-llc#564)

* [11.0][PORT] pos_longpolling, pos_multi_session, pos_multi_session_restaurant (it-projects-llc#555)

* [11.0][PORT] porting pos_longpolling from 10.0 to 11.0

* [11.0][PORT] porting pos_multi_session and pos_multi_session_sync

* [11.0][PORT] porting pos_multi_session_restaurant from 10.0 to 11.0

* [ADD] pos_invoice_pay 11.0 config buttons

* [FIX] UI fix: preventing to open multiple lines

* [ADD] pos_longpolling

* [LINT] lint fixes

ilmir-k added a commit to ilmir-k/pos-addons that referenced this pull request Aug 9, 2018

[11.0][PORT] pos_invoice_pay to 11.0 (it-projects-llc/addons-dev#365)
* [11.0][PORT] pos_invoice_pay to 11.0

* [11.0][PORT] pos debt notebook port (it-projects-llc#557)

* [DOC] pos_order_note: new price and demo url (it-projects-llc#564)

* [11.0][PORT] pos_longpolling, pos_multi_session, pos_multi_session_restaurant (it-projects-llc#555)

* [11.0][PORT] porting pos_longpolling from 10.0 to 11.0

* [11.0][PORT] porting pos_multi_session and pos_multi_session_sync

* [11.0][PORT] porting pos_multi_session_restaurant from 10.0 to 11.0

* [ADD] pos_invoice_pay 11.0 config buttons

* [FIX] UI fix: preventing to open multiple lines

* [ADD] pos_longpolling

* [LINT] lint fixes
from odoo.exceptions import UserError


def pre_uninstall(cr, registry):
env = api.Environment(cr, SUPERUSER_ID, {})
env = api.Environment({})

This comment has been minimized.

@yelizariev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment