Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 discount #797

Merged
merged 6 commits into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@GabbasovDinar
Copy link
Member

GabbasovDinar commented Oct 22, 2018

No description provided.

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Oct 23, 2018

Depends on #795

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Oct 23, 2018

Please read meaning of 🛡 and 🌈 tags

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-discount branch from 269c53c to 1c4683b Oct 25, 2018

@yelizariev
Copy link
Member

yelizariev left a comment

Code changes look good

@Ramil-Mukhametzyanov
Copy link
Member

Ramil-Mukhametzyanov left a comment

Module passed the test on the runbot

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 13, 2018

2018-11-12 10:43:09,068 2918 ERROR 23715-797-1c4683-base odoo.modules.graph: module pos_print_method: Unmet dependencies: pos_restaurant_base

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-discount branch from 1c4683b to fc78c05 Nov 13, 2018

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 13, 2018

2018-11-13 09:38:35,694 3863 WARNING 23780-797-fc78c0-base odoo.models: The model pos.category_discount has no _description

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-discount branch 2 times, most recently from 414bc45 to 6bbd5c1 Nov 13, 2018

GabbasovDinar added some commits Oct 17, 2018

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-discount branch from 6bbd5c1 to b1f79c5 Nov 14, 2018

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 14, 2018

Green 💚 💚 !

@yelizariev yelizariev merged commit 5008a27 into it-projects-llc:12.0 Nov 14, 2018

6 checks passed

Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 23882-797-b1f79c (runtime 473s)
Details
codecov/patch/backend Coverage not affected when comparing 5eaec53...b1f79c5
Details
codecov/patch/tests 100% of diff hit (target 100%)
Details
coverage/coveralls Coverage increased (+4.7%) to 84.568%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.