Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 polling #807

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
5 participants
@GabbasovDinar
Copy link
Member

GabbasovDinar commented Oct 29, 2018

No description provided.

@houndci-bot
Copy link

houndci-bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@yelizariev yelizariev requested a review from KolushovAlexandr Nov 1, 2018

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-polling branch from 705ad9e to caa583c Nov 13, 2018

Show resolved Hide resolved pos_longpolling/static/src/js/pos.js Outdated

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-polling branch from caa583c to 8cbca79 Nov 13, 2018

@KolushovAlexandr
Copy link
Member

KolushovAlexandr left a comment

The code was totally refactored, almost all relations and chains of functions are different now. It works. It would be better to test it together with the ported pos_multi_session_sync module

@GabbasovDinar

This comment has been minimized.

Copy link
Member Author

GabbasovDinar commented Nov 13, 2018

@KolushovAlexandr You can test here #790

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 13, 2018

@KolushovAlexandr I still need your review for the code itself

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 13, 2018

At least about refactored part

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-polling branch 3 times, most recently from a0b91d8 to 3aece49 Nov 13, 2018

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-polling branch from 3aece49 to 8e26f70 Nov 14, 2018

@Ramil-Mukhametzyanov
Copy link
Member

Ramil-Mukhametzyanov left a comment

It works. I checked it on the Discuss app.

@KolushovAlexandr
Copy link
Member

KolushovAlexandr left a comment

I checked changes locally, they work correctly

@yelizariev yelizariev merged commit a21bddb into it-projects-llc:12.0 Nov 15, 2018

5 of 6 checks passed

coverage/coveralls Coverage decreased (-7.7%) to 72.093%
Details
Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 23963-807-8e26f7 (runtime 369s)
Details
codecov/patch/backend Coverage not affected when comparing 5eaec53...8e26f70
Details
codecov/patch/tests Coverage not affected when comparing 5eaec53...8e26f70
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.