Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 multi session #809

Merged
merged 4 commits into from Nov 20, 2018

Conversation

Projects
None yet
4 participants
@GabbasovDinar
Copy link
Member

GabbasovDinar commented Oct 29, 2018

related with #807

@houndci-bot
Copy link

houndci-bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 13, 2018

Please rebase to upstream to restart travis with proper configuration

@yelizariev
Copy link
Member

yelizariev left a comment

Code looks good, though following commit message doesn't explain why it's better

😍 don't use the 'change' trigger to save to the local storage

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-multi-session branch 7 times, most recently from 7d214f2 to 4064b97 Nov 13, 2018

@Ramil-Mukhametzyanov
Copy link
Member

Ramil-Mukhametzyanov left a comment

No errors were found

GabbasovDinar added some commits Oct 25, 2018

🚑 fix rerendering the Products list after change a current order.
Before this fix if we have a rerender of the product list every time, then we will get a hang and slow response of the system.

@GabbasovDinar GabbasovDinar force-pushed the GabbasovDinar:12.0-multi-session branch from 4064b97 to f367be2 Nov 19, 2018

@yelizariev yelizariev merged commit 69a1925 into it-projects-llc:12.0 Nov 20, 2018

5 of 6 checks passed

coverage/coveralls Coverage decreased (-3.1%) to 71.472%
Details
Hound No violations found. Woof!
ci/branches Branch names are correct
Details
ci/runbot runbot build 24200-809-f367be (runtime 406s)
Details
codecov/patch/backend Coverage not affected when comparing 0db2971...f367be2
Details
codecov/patch/tests Coverage not affected when comparing 0db2971...f367be2
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.