Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:ambulance: fix db name vulnerability #19

Merged

Conversation

@trojikman
Copy link
Member

commented Jul 11, 2019

No description provided.

@yelizariev
Copy link
Member

left a comment

I'd prefer to fixing name on saving

saas/models/saas_db.py Outdated Show resolved Hide resolved
@yelizariev
Copy link
Member

left a comment

Consider to clean up the commits

saas/doc/changelog.rst Outdated Show resolved Hide resolved

@trojikman trojikman force-pushed the trojikman:12.0-saas-fix-bug-with-db-name branch from 87a1b0d to 7094fa4 Jul 15, 2019

saas/demo/saas_template_demo.xml Outdated Show resolved Hide resolved

@trojikman trojikman force-pushed the trojikman:12.0-saas-fix-bug-with-db-name branch 2 times, most recently from 8319214 to 9576b52 Jul 15, 2019

@yelizariev
Copy link
Member

left a comment

Looks good, but squash commits

@trojikman trojikman force-pushed the trojikman:12.0-saas-fix-bug-with-db-name branch from 9576b52 to 9c8f301 Jul 15, 2019

@trojikman

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

Looks good, but squash commits

Done

@yelizariev

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

I approve to merge it now

4 similar comments
@yelizariev

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

I approve to merge it now

@yelizariev

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

I approve to merge it now

@yelizariev

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

I approve to merge it now

@yelizariev

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

I approve to merge it now

@itpp-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Approved by @yelizariev

@yelizariev yelizariev merged commit 35eb3e2 into it-projects-llc:12.0 Jul 16, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
ci/branches Branch names are correct
Details
ci/runbot runbot build 01327-19-9c8f30 (runtime 149s)
Details

@trojikman trojikman deleted the trojikman:12.0-saas-fix-bug-with-db-name branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.