Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:ambulance: for communications between the build and the master you need to use the base url #22

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@trojikman
Copy link
Member

commented Jul 15, 2019

No description provided.

@@ -73,7 +73,7 @@ def generate_db_name(self):

def _get_mandatory_args(self, db):
self.ensure_one()
master_url = self.master_url
master_url = self.env['ir.config_parameter'].get_param('web.base.url')

This comment has been minimized.

Copy link
@yelizariev

yelizariev Jul 15, 2019

Member

The same is the same as server-to-server communication. Can we rename one of them to avoid confusion? E.g. link_to_master for Server-to-server value ?

This comment has been minimized.

Copy link
@trojikman

trojikman Jul 15, 2019

Author Member

Ok

@yelizariev yelizariev merged commit a813bdc into it-projects-llc:12.0 Jul 16, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
ci/branches Branch names are correct
Details
ci/runbot runbot build 01324-22-b274a1 (runtime 150s)
Details
@yelizariev

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

I approve to merge it now

@itpp-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Approved by @yelizariev

@trojikman trojikman deleted the trojikman:12.0-saas-master-url branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.