Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:lock: default saas-access for user, admin #29

Open
wants to merge 1 commit into
base: 12.0
from

Conversation

@fedoranvar
Copy link
Contributor

commented Aug 6, 2019

No description provided.

@@ -8,13 +8,14 @@
<record model="res.groups" id="group_user">
<field name="name">User</field>
<field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
<field name="users" eval="[(4, ref('base.user_root'))]"/>
<field name="users" eval="[(4, ref('base.user_demo'))]"/>

This comment has been minimized.

Copy link
@trojikman

trojikman Aug 6, 2019

Member

I think it's better to separate user_demo like this: https://github.com/odoo/odoo/blob/12.0/addons/lunch/data/lunch_demo.xml#L6
We have demo directory for it. Here, just as before, use user_root

<field name="category_id" ref="saas.module_management"/>
</record>

<record model="res.groups" id="group_manager">
<field name="name">Manager</field>
<field name="implied_ids" eval="[(4, ref('saas.group_user'))]"/>
<field name="users" eval="[(4, ref('base.user_admin'))]"/>

This comment has been minimized.

Copy link
@trojikman

trojikman Aug 6, 2019

Member

Complete this entry with this: (4, ref('base.user_root'))

This comment has been minimized.

Copy link
@fedoranvar

fedoranvar Aug 7, 2019

Author Contributor

I'm not quite sure, but if we add (4, ref('base.user_root')) to (4, ref('base.user_admin')), then average users will have saas-manager-rights

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 16, 2019

Member

You need to add both values: for superuser and for admin-admin

@yelizariev
Copy link
Member

left a comment

you reference to demo data outside of demo files

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-saas-minor branch from db07922 to 302c24b Aug 7, 2019

@@ -13,4 +13,7 @@
<field name="template_id" eval="ref('saas_template')"/>
<field name="operator_id" eval="ref('local_operator')"/>
</record>
<record model="res.groups" id="saas.group_user">
<field name="users" eval="[(4, ref('base.user_root')),(4, ref('base.user_demo'))]"/>
</record>

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 16, 2019

Member

Use another file. You put security stuff in file named "template"

<field name="category_id" ref="saas.module_management"/>
</record>

<record model="res.groups" id="group_manager">
<field name="name">Manager</field>
<field name="implied_ids" eval="[(4, ref('saas.group_user'))]"/>
<field name="users" eval="[(4, ref('base.user_admin'))]"/>

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 16, 2019

Member

You need to add both values: for superuser and for admin-admin

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-saas-minor branch from 302c24b to ed6ca3b Aug 19, 2019

@@ -15,6 +17,7 @@
<record model="res.groups" id="group_manager">
<field name="name">Manager</field>
<field name="implied_ids" eval="[(4, ref('saas.group_user'))]"/>
<field name="users" eval="[(4, ref('base.user_admin')),(4, ref('base.group_system')) ]"/>

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 19, 2019

Member

group_system is not a user

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-saas-minor branch 3 times, most recently from e4cafb1 to 0671936 Aug 19, 2019

@@ -8,13 +10,14 @@
<record model="res.groups" id="group_user">
<field name="name">User</field>
<field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
<field name="users" eval="[(4, ref('base.user_root'))]"/>
<field name="users" eval="[(4, ref('base.default_user'))]"/>

This comment has been minimized.

Copy link
@yelizariev

yelizariev Aug 20, 2019

Member

You shall not update user template

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-saas-minor branch from 0671936 to 9ef72ad Aug 20, 2019

@fedoranvar fedoranvar force-pushed the fedoranvar:12.0-saas-minor branch from 9ef72ad to 921263b Aug 21, 2019

@@ -9,6 +9,7 @@

def rpc_auth(url, db_name, admin_username='admin', admin_password='admin'):
# Authenticate

This comment has been minimized.

Copy link
@hound

hound bot Aug 21, 2019

blank line contains whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.