New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] website_sale_add_to_cart: 11.0 #237

Merged
merged 12 commits into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@KolushovAlexandr
Copy link
Member

KolushovAlexandr commented Nov 9, 2017

No description provided.

@ilmir-k

This comment has been minimized.

Copy link
Member

ilmir-k commented Nov 9, 2017

@KolushovAlexandr fix lints


Installation
============
{Instruction about things to do before actual installation}

This comment has been minimized.

@yelizariev
@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 10, 2017

update .travis.yml

KolushovAlexandr added some commits Nov 10, 2017

@KolushovAlexandr

This comment has been minimized.

Copy link
Member

KolushovAlexandr commented Nov 10, 2017

@ilmir-k Only # -*- coding: utf-8 -*- errores are remained in LINT.
@yelizariev In tests i've got a strange error arising after typing a text in an 'input' and click anything else but the 'input'. I need consultation about that because in checkout_store situation is the same.

@ilmir-k

This comment has been minimized.

Copy link
Member

ilmir-k commented Nov 10, 2017

@KolushovAlexandr it is because you removed # -- coding: utf-8 -- from the files. Return it back

@KolushovAlexandr

This comment has been minimized.

Copy link
Member

KolushovAlexandr commented Nov 13, 2017

@ilmir-k How i've understood Ivan said he is going to remove this lint error for version 11

@ilmir-k

This comment has been minimized.

Copy link
Member

ilmir-k commented Nov 13, 2017

@KolushovAlexandr ok, you can skip it

KolushovAlexandr added some commits Nov 14, 2017

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 17, 2017

merge upstream to resolve conflicts

@yelizariev

This comment has been minimized.

Copy link
Member

yelizariev commented Nov 23, 2017

Fix conflicts

KolushovAlexandr added some commits Nov 23, 2017

Merge branch '11.0-website_sale_add_to_cart-port' of github.com:Kolus…
…hovAlexandr/website-addons into 11.0-website_sale_add_to_cart-port

@ilmir-k ilmir-k merged commit c7c69a1 into it-projects-llc:11.0 Nov 23, 2017

4 checks passed

ci/branches Branch names are correct
Details
ci/runbot runbot build 11168-237-b8355c (runtime 518s)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+53.7%) to 88.095%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment