Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for issue #1 #4

Merged
merged 4 commits into from Nov 22, 2017

Conversation

@HoochDeveloper
Copy link
Member

commented Oct 8, 2017

Issue: #1

Samples for reading NIS in C++, Java, Objective-C

@HoochDeveloper

This comment has been minimized.

Copy link
Owner Author

commented on 8b5318b Oct 8, 2017

This code is for MacOSX

@alranel alranel merged commit ef98202 into italia:master Nov 22, 2017

@alranel

This comment has been minimized.

Copy link
Member

commented Nov 22, 2017

Hello!

I initially merged your pull request because I thought about having a single cie-nis-sdk repository with your code and the Python one (from the other pull request) but I realized this would prevent us from having TravisCI running.
So I'm going to create additional individual repositories for your code: cie-nis-java-sdk, cie-nis-objc-sdk, cie-nis-cpp-sdk.

I have one question before proceeding: why did you relicense the repository from BSD-3 (our preferred license) to Apache?

@duncanwilcox

This comment has been minimized.

Copy link

commented Nov 22, 2017

The MacOS code is derivative of https://github.com/dirkx/CryptoTokenKit-TrivialExample-OpenSC which is Apache licensed.

@alranel

This comment has been minimized.

Copy link
Member

commented Nov 23, 2017

I just created three new repositories for your code and pulled it preserving history:
https://github.com/italia/cie-nis-cpp-sdk
https://github.com/italia/cie-nis-java-sdk
https://github.com/italia/cie-nis-objc-sdk

Thank you for your contribution, and welcome to the community of Developers Italia as maintainers of the above repositories, on which you now have full admin rights 😃
(Remember: with great power comes great responsibility.)

I also invited you to become part of the italia organization, so that you can display its logo on your profile (don't forget to change the visibility after you accept the invitation!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.