Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/add Flask-Security-Too #35

Closed
jwag956 opened this issue Nov 14, 2019 · 6 comments
Closed

Update/add Flask-Security-Too #35

jwag956 opened this issue Nov 14, 2019 · 6 comments

Comments

@jwag956
Copy link

jwag956 commented Nov 14, 2019

For the past 6 months I have been resurrecting Flask-Security - alas requiring my own fork at:
https://github.com/jwag956/flask-security

The original Flask-Security basically has stopped being maintained. I would like to either
ADD Flask-Security-Too as an additional supported extension OR replace Flask-Security.

I am willing to do the PR - just want guidance/approval of the idea.

@italomaia
Copy link
Owner

Hey @jwag956 how are you? So, last time I checked, flask-security had a new maintainer. That is exactly why I put it back into the extensions list (flask-security-fork was being used). I would like to try and involve them in the loop before taking action, given flask-security popularity.
I'll also take some time to check your fork.

@italomaia
Copy link
Owner

@jwag956
Copy link
Author

jwag956 commented Nov 14, 2019

Thanks - yes - there was - but nothing came of that - which is why I started my own, at first I just released existing/approved PRs - then started modernizing.
You might want to scroll through this:
pallets-eco/flask-security#822

@italomaia
Copy link
Owner

Seems flask-security is left to the moths. Mind if we discuss flask-security-too a bit @jwag956 ? Gonna ping you privately for some details but would like to know a few things:
Who are the maintainers for flask-security-too? What is the goal of the project (short, mid and long term)?

PS: Thank you for opening this ticket and bringing my attention to this major issue.

@jwag956
Copy link
Author

jwag956 commented Nov 25, 2019

Sure - my email is on my profile.
A short overview is on my README:
https://github.com/jwag956/flask-security

Right now - it's just me - I have had around a dozen PRs - mostly small - although the two-factor auth PR was a large feature done by someone else.
Since I couldn't just take over 'Flask-Security' package - it will be a slow road to get 'noticed'. That's one reason I reached out to you - and have proposed a PR to flask-admin showing how to integrate with my fork (both flask-empty and flask-admin are very popular).

@italomaia
Copy link
Owner

It is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants