New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of FreeBSD Jail #249

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@yuichiro-naito
Contributor

yuichiro-naito commented Aug 31, 2017

I reopened #245 .
This pull request has only one fix which adds support of FreeBSD Jail.
Following message is my original pull request.

I wrote a patch that makes Itamae to support FreeBSD jail (*1).
I tested all Itamae resources work with Specinfra-2.70.1.

My fix is quite simple.

  • added jexec backend which executes specinfra commands in jail.
  • added Itamae jail subcommand.

Here is a example to use Itamae jail subcommand.

$ su
# itamae jail --jail_name <jail_name> <recipe> ...

Itamae jail subcommand requires root privilege,
because FreeBSD's jexec command requires root privilege.

Will you see my fixes and merge this Pull Request?

*1: FreeBSD jail information
https://www.freebsd.org/doc/handbook/jails.html
https://ja.wikipedia.org/wiki/FreeBSD_jail

@yuichiro-naito

This comment has been minimized.

Contributor

yuichiro-naito commented Oct 10, 2017

Over one month has passed since I created this Pull Request.
Are there any issues about stopping development?

@yuichiro-naito

This comment has been minimized.

Contributor

yuichiro-naito commented Nov 20, 2017

I want to use this feature on FreeBSD.
Please merge and release new version.

@sue445

This comment has been minimized.

Member

sue445 commented Oct 14, 2018

@yuichiro-naito Sorry for late reply.

I think this is LGTM, but CI is broken at your branch. Please rebase (or merge ) latest master.

@sue445 sue445 self-requested a review Oct 15, 2018

Merge branch 'master' into feature/FreeBSD_jail
for CI testing has been fixed on master branch.
@yuichiro-naito

This comment has been minimized.

Contributor

yuichiro-naito commented Oct 15, 2018

I have merged master branch.
All tests are passed successfully.

@sue445 sue445 merged commit 4dfeb06 into itamae-kitchen:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sue445

This comment has been minimized.

Member

sue445 commented Oct 16, 2018

@yuichiro-naito v1.9.12 is released 💎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment