New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail `--ohai` option when using ohai v13.0.1 or higher #240 #251

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@fuminori-ido
Contributor

fuminori-ido commented Sep 8, 2017

Regarding to #240, let me submit this PR. Here the summary of the issue:

Phenomenon

itamae ssh --ohai fails when ohai >= v8.24.0 is installed at the target host.

Reason

  1. Net::SSH (or openssh) with pty merges stdout and stderr as discussed at net-ssh/net-ssh#51
  2. ohai generates INFO message to stderr. Since v8.24.0, it checks whether if /etc/chef/ohai/plugins directory exists and report to stderr. This message is merged into stdout on ssh because of 1. above so that ohai output is corrupted.

Workaround

Workaround might be:

  1. fix Net::SSH, or
  2. mkdir /etc/chef/ohai/plugins at ohai executed host, or
  3. isolate stderr from stdout at itamae side.

This PR is 3rd one above.

@sue445

This comment has been minimized.

Member

sue445 commented Oct 14, 2018

@fuminori-ido Sorry for late reply.

I think this is LGTM, but CI is broken at your branch. Please rebase (or merge ) latest master.

@sue445 sue445 self-requested a review Oct 15, 2018

@sue445 sue445 merged commit 7f5d5fd into itamae-kitchen:master Nov 23, 2018

1 check failed

continuous-integration/wercker Wercker build failed
Details
@sue445

This comment has been minimized.

Member

sue445 commented Nov 23, 2018

I merged this PR at #272 and released at v1.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment