New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing integration spec (including workaround) #253

Closed
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@unasuke
Member

unasuke commented Jan 29, 2018

changes

  • use system vagrant
  • use ubuntu 16.04 (xenial)
    • in ubuntu 14.04, package 'ruby' is EOL version (1.9)
  • update 'sl' version
  • add 'not_if' attribute to execute mkdir resources
  • remove 'action' attribute from file '/tmp/file_edit_with_suid' (workaround)
    • in action: edit causes exception Net::SCP::Error

require

reference

unasuke added some commits Dec 8, 2017

Tweak Vagrantfile
- use system Vagrant (remove require)
- remove VAGRANTFILE_API_VERSION
Use system vagrant
install vagrant from rubygems is outdated
Update wercker.yml
- use drecom/ubuntu-ruby:2.3.1 to base box
- split build step
- vagrant from official release package

ref http://sue445.hatenablog.com/entry/2016/04/07/195627
Use ubuntu 16.04 (xenial)
ubuntu 14.04 is outdated
Update sl package version
version changed in ubuntu 14.04 -> 16.04
Remove outdated command (upstart)
ubuntu 16.04 use systemd.
Remove execute resouece that dependent upstart.
Use default action in file resource (workaround)
fail spec by Net::SCP::Error
@unasuke

This comment has been minimized.

Member

unasuke commented Feb 19, 2018

@ryotarai Hou about it? Is something missing?

box: wercker/rvm
# Build definition
box: drecom/ubuntu-ruby:2.3.1
build:

This comment has been minimized.

@ryotarai

ryotarai Mar 30, 2018

Member

https://app.wercker.com/buildstep/5a6ef7bfc16a530100f6b298 says build/steps is not of required type.

build:
  steps:

should this be removed? (I'm not sure whether this fixes the problem...)

This comment has been minimized.

@unasuke

unasuke Apr 2, 2018

Member

Thank you for a review!

The pull-req uses wercker classic stack and configure workflow and pipeline on web UI.

e.g.
screenshot from 2018-04-02 18-41-21

So, please configure your wercker project ryotarai/ itamae 🙏

see also http://sue445.hatenablog.com/entry/2016/04/07/195627#Wercker%E3%81%AE%E8%A8%AD%E5%AE%9A

This comment has been minimized.

@ryotarai

ryotarai Apr 13, 2018

Member

image

It already looks to be on classic stack and Wercker says we should migrate to new stack.

This comment has been minimized.

@unasuke

unasuke Apr 15, 2018

Member

oh……

This comment has been minimized.

@sue445

sue445 May 28, 2018

Member

The pull-req uses wercker classic stack

No. This PR already looks like a workflow style.

I think we should change to workflow stack on console.

c.f. https://sue445.hatenablog.com/entry/2016/08/12/133645

@ryotarai

This comment has been minimized.

Member

ryotarai commented Oct 8, 2018

Thank you for fixing this problem but #258 looks better, I think. So let me close this PR. Thank you again.

@ryotarai ryotarai closed this Oct 8, 2018

@unasuke unasuke deleted the unasuke:fail_spec branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment