New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerlize and migrate to TravisCI #258

Merged
merged 5 commits into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@sue445
Member

sue445 commented May 30, 2018

Changes

Before

  • VirtualBox (only local)
  • DIgitalOcean (only CI)
  • Vagrant
  • Wercker

After

  • Docker (both local and CI)
  • TravisCI

Why?

Build of this repo is failed a long time.

itamae uses Wercker (legacy stack).
#253 (comment)

I thought it was faster to create a new one in Travis CI than to make the existing Wercker follow the latest.

Pros

Dockerlize

  • No overhead due to SSH connection
  • Same environment between local and CI
    • Both local and CI use ubuntu trusty, but they are strictly different.

Migration to TravisCI

  • CI setting is complete with yaml file
    • Wercker needs console operation by admin when change workflow configuration

Cons

  • Migration cost for dockerlize

Note

@sue445

This comment has been minimized.

Show comment
Hide comment
@sue445

sue445 Jul 17, 2018

Member

@ryotarai Do you think this PR?

Member

sue445 commented Jul 17, 2018

@ryotarai Do you think this PR?

@ryotarai

This comment has been minimized.

Show comment
Hide comment
@ryotarai

ryotarai Jul 18, 2018

Member

Sorry for late response and thank you for great PR 馃帀 I'll merge this in a few days

Member

ryotarai commented Jul 18, 2018

Sorry for late response and thank you for great PR 馃帀 I'll merge this in a few days

@ryotarai ryotarai merged commit b69ad55 into itamae-kitchen:master Oct 8, 2018

1 check passed

continuous-integration/wercker Wercker build passed
Details
@ryotarai

This comment has been minimized.

Show comment
Hide comment
@ryotarai

ryotarai Oct 8, 2018

Member

I'm very sorry for leaving this PR opened. I've merged this right now.

Member

ryotarai commented Oct 8, 2018

I'm very sorry for leaving this PR opened. I've merged this right now.

@sue445 sue445 referenced this pull request Oct 10, 2018

Merged

Migrate to TravisCI badge #260

@sue445 sue445 deleted the sue445:travisci_docker branch Oct 15, 2018

@sue445 sue445 referenced this pull request Oct 17, 2018

Merged

Migrate to TravisCI badge #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment