New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rspec warning #267

Merged
merged 1 commit into from Oct 20, 2018

Conversation

Projects
None yet
2 participants
@sue445
Member

sue445 commented Oct 20, 2018

c.f. https://travis-ci.org/itamae-kitchen/itamae/jobs/444002797

WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives,
since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`,
potentially allowing the expectation to pass without even executing the method you are intending to call.
Actual error raised was RuntimeError. Instead consider providing a specific error class or message.
This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`.
Called from /home/travis/build/itamae-kitchen/itamae/spec/unit/lib/itamae/handler_proxy_spec.rb:22:in `block (5 levels) in <module:Itamae>'.

@unasuke

Fixed rspec warning
c.f. https://travis-ci.org/itamae-kitchen/itamae/jobs/444002797

```
WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives,
since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`,
potentially allowing the expectation to pass without even executing the method you are intending to call.
Actual error raised was RuntimeError. Instead consider providing a specific error class or message.
This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`.
Called from /home/travis/build/itamae-kitchen/itamae/spec/unit/lib/itamae/handler_proxy_spec.rb:22:in `block (5 levels) in <module:Itamae>'.
```

@unasuke unasuke self-requested a review Oct 20, 2018

@unasuke

👍

@sue445 sue445 merged commit 01e059a into master Oct 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sue445 sue445 deleted the rspec_error_warning branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment