Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mash warnings (review catch up) #273

Merged
merged 3 commits into from Dec 14, 2018

Conversation

@unasuke
Copy link
Member

@unasuke unasuke commented Dec 14, 2018

original pull request description ( by @hnmx4 )

for #243.
I use a Hashie developer’s solution that solves issue similar to issue#243 as reference.

hashie/hashie#394

I just released Hashie v3.5.2 which has the disable_warnings feature for the Mash logger and sets the Hashie logger to the Rails logger when we detect that we're running in Rails. Hopefully, this helps!

https://github.com/intridea/hashie

You can also disable the logging in subclasses of Mash:

class Response < Hashie::Mash
  disable_warnings
end

I added commits for @sue445 's comment

I prefer add require 'itamae/mash' to lib/itamae.rb than here.

#244 (comment)

hnmx4 and others added 3 commits Jul 28, 2017
to use Itamae::Mash in the whole of itamae
to suppress hashie warning messages
@unasuke unasuke self-assigned this Dec 14, 2018
@unasuke unasuke requested a review from sue445 Dec 14, 2018
@sue445
sue445 approved these changes Dec 14, 2018
Copy link
Member

@sue445 sue445 left a comment

LGTM!

@unasuke
Copy link
Member Author

@unasuke unasuke commented Dec 14, 2018

YAY!

@unasuke unasuke merged commit 2d1f66a into itamae-kitchen:master Dec 14, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@unasuke unasuke deleted the unasuke:disable-mash-warnings branch Dec 14, 2018
@unasuke unasuke mentioned this pull request Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants