Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description to --tag option of docker subcommand #286

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Add description to --tag option of docker subcommand #286

merged 1 commit into from
Apr 26, 2019

Conversation

pocke
Copy link
Contributor

@pocke pocke commented Apr 26, 2019

I think --tag option name is not descriptive. I did not understand the option behavior without reading the implementation.
So adding a description to the option is helpful.

@unasuke unasuke self-assigned this Apr 26, 2019
@unasuke unasuke self-requested a review April 26, 2019 06:37
@unasuke unasuke removed their assignment Apr 26, 2019
unasuke
unasuke approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 👍

@unasuke unasuke merged commit 9e4a80f into itamae-kitchen:master Apr 26, 2019
@pocke pocke deleted the add-description-of-dokcer-tag branch April 26, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unasuke unasuke unasuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pocke @unasuke