Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine `itamae docker`'s created message #288

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@pocke
Copy link
Contributor

commented May 10, 2019

This change will make itamae docker command to display tag name after the image is created if tag option is specified.

For example:

$ bundle exec itamae docker --image base-image path/to/role.rb --tag awesome-something:latest

(snip)

 INFO : Image created: sha256:24b0ede58da84ed28bafb629121d16b87e2d36cb96d8361413fdb2555876cac8, and tagged as awesome-something:latest

I think displaying created tag name is useful. It remind me the tag name.
And it is the same behaviour with docker build command.

$ docker build -t foo:bar .

(snip)

Successfully built 24b0ede58da8
Successfully tagged foo:bar
Refine `itamae docker`'s created message
This change will make `itamae docker` command to display tag name after the image is created if `tag` option is specified.

For example:

```
$ bundle exec itamae docker --image base-image path/to/role.rb --tag awesome-something:latest

(snip)

 INFO : Image created: sha256:24b0ede58da84ed28bafb629121d16b87e2d36cb96d8361413fdb2555876cac8, and tagged as awesome-something:latest
```

I think displaying created tag name is useful. It remind me the tag name.
And it is the same behaviour with `docker build` command.

```
$ docker build -t foo:bar .

(snip)

Successfully built 24b0ede58da8
Successfully tagged foo:bar
```
Show resolved Hide resolved lib/itamae/backend.rb Outdated
Update lib/itamae/backend.rb
Co-Authored-By: Yusuke Nakamura <unasuke@users.noreply.github.com>
@unasuke
Copy link
Member

left a comment

Good thanks! 😆

@unasuke unasuke merged commit 6bec659 into itamae-kitchen:master May 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pocke pocke deleted the pocke:refine-itamae-docker-message branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.