Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test cases correctly #289

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
2 participants
@pocke
Copy link
Contributor

commented May 10, 2019

Since #281 , spec for integration tests are not executed.

Because the pattern is not correct. [default|docker] is bad for OR pattern.
It should be {default,docker}.
https://relishapp.com/rspec/rspec-core/v/3-8/docs/command-line/pattern-option#the-%60--pattern%60-flag-accepts-shell-style-glob-unions

This change makes the test cases to be executed.

It was introduced by me. I'm sorry馃檱馃檱

Before

$ bundle exec rake spec:integration:ubuntu:trusty

(snip)

/home/pocke/.rbenv/versions/trunk/bin/ruby -I ./spec/integration -I/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/lib:/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-support-3.8.0/lib /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/integration/\[default\|docker\]_spec.rb
No examples found.

Finished in 0.00016 seconds (files took 0.03293 seconds to load)
0 examples, 0 failures

After

$ bundle exec rake spec:integration:ubuntu:trusty

(snip)

/home/pocke/.rbenv/versions/trunk/bin/ruby -I ./spec/integration -I/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/lib:/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-support-3.8.0/lib /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/integration/\{default,docker\}_spec.rb

(snip)

Finished in 13.9 seconds (files took 0.28032 seconds to load)
139 examples, 0 failures
Run test cases correctly
Since #281 , spec for integration tests are not executed.

Because the pattern is not correct. `[default|docker]` is bad for OR pattern.
It should be `{default,docker}`.

It was introduced by me. I'm sorry馃檱馃檱

Before
===

```console
$ bundle exec rake spec:integration:ubuntu:trusty

(snip)

/home/pocke/.rbenv/versions/trunk/bin/ruby -I ./spec/integration -I/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/lib:/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-support-3.8.0/lib /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/integration/\[default\|docker\]_spec.rb
No examples found.

Finished in 0.00016 seconds (files took 0.03293 seconds to load)
0 examples, 0 failures
```

After
===

```console
$ bundle exec rake spec:integration:ubuntu:trusty

(snip)

/home/pocke/.rbenv/versions/trunk/bin/ruby -I ./spec/integration -I/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/lib:/home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-support-3.8.0/lib /home/pocke/.rbenv/versions/trunk/lib/ruby/gems/2.7.0/gems/rspec-core-3.8.0/exe/rspec --pattern spec/integration/\{default,docker\}_spec.rb

(snip)

Finished in 13.9 seconds (files took 0.28032 seconds to load)
139 examples, 0 failures
```

@sue445 sue445 merged commit 183bc10 into itamae-kitchen:master May 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pocke pocke deleted the pocke:fix-rakefile-to-run-test branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.