Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support thor-1.1.0 #329

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Support thor-1.1.0 #329

merged 1 commit into from
Feb 4, 2021

Conversation

chaaaaarlotte
Copy link
Contributor

Fixed the following errors

$ itamae
/home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/thor-1.1.0/lib/thor/shell/basic.rb:393:in `quiet?': private method `options' called for #<Itamae::CLI:0x00000000018cf158 @_invocations={Itamae::CLI=>["help"]}, @_initializer=[[], [], {:shell=>#<Thor::Shell::Color:0x00000000018cf608 @base=#<Itamae::CLI:0x00000000018cf158 ...>, @mute=false, @padding=0, @always_force=false>, :current_command=>#<struct Thor::Command name="help", description="Describe available commands or one specific command", long_description=nil, usage="help [COMMAND]", options={}, ancestor_name=nil>}], @options={}, @args=[], @shell=#<Thor::Shell::Color:0x00000000018cf608 @base=#<Itamae::CLI:0x00000000018cf158 ...>, @mute=false, @padding=0, @always_force=false>, @itamae_options={}> (NoMethodError)
Did you mean?  options=
	from /home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/thor-1.1.0/lib/thor/shell/basic.rb:97:in `say'
	from /home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/thor-1.1.0/lib/thor.rb:205:in `help'
	from /home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/thor-1.1.0/lib/thor.rb:513:in `help'
	from /home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/thor-1.1.0/lib/thor/command.rb:27:in `run'
	from /home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/thor-1.1.0/lib/thor/invocation.rb:127:in `invoke_command'
	from /home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/thor-1.1.0/lib/thor.rb:392:in `dispatch'
	from /home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/thor-1.1.0/lib/thor/base.rb:485:in `start'
	from /home/takafumi/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/itamae-1.11.1/bin/itamae:4:in `<top (required)>'
	from /home/takafumi/.rbenv/versions/3.0.0/bin/itamae:23:in `load'
	from /home/takafumi/.rbenv/versions/3.0.0/bin/itamae:23:in `<main>'

@unasuke unasuke self-assigned this Feb 3, 2021
@sue445 sue445 self-assigned this Feb 4, 2021
@sue445 sue445 requested review from sue445 and unasuke February 4, 2021 00:28
sue445
sue445 approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♀️

lib/itamae/cli.rb Outdated
@@ -117,7 +117,7 @@ def destroy(target, name)
end

private
def options
def self.options
Copy link
Member

@sue445 sue445 Feb 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works with both thor v1.1.0 and thor v1.0.1 👍

unasuke
unasuke reviewed Feb 4, 2021
View reviewed changes
Copy link
Member

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed it works. But the self.options method is declared under the private modifier it's not a private method. It's confusing.
Cloud you move this class method up to the private modifier?

unasuke
unasuke approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@unasuke unasuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@unasuke unasuke merged commit d3dabc1 into itamae-kitchen:master Feb 4, 2021
@chaaaaarlotte chaaaaarlotte deleted the support_thor-1.1.0 branch February 4, 2021 04:16
@unasuke
Copy link
Member

unasuke commented Feb 4, 2021

I will release it today.

@unasuke
Copy link
Member

unasuke commented Feb 4, 2021

Released
https://github.com/itamae-kitchen/itamae/releases/tag/v1.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sue445 sue445 sue445 approved these changes

@unasuke unasuke unasuke approved these changes

Assignees

@sue445 sue445

@unasuke unasuke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaaaaarlotte @unasuke @sue445