New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .love games out of the box #135

Closed
fasterthanlime opened this Issue Dec 15, 2015 · 10 comments

Comments

Projects
None yet
6 participants
@fasterthanlime
Member

fasterthanlime commented Dec 15, 2015

Only question is how do they let us know which love version they need?

@Ragzouken

This comment has been minimized.

Show comment
Hide comment
@Ragzouken

Ragzouken Dec 15, 2015

you could extract https://love2d.org/wiki/Config_Files from the .love and try to extract the version number (foolproof would be to execute the lua file, but then you'd need to embed lua lol)

Ragzouken commented Dec 15, 2015

you could extract https://love2d.org/wiki/Config_Files from the .love and try to extract the version number (foolproof would be to execute the lua file, but then you'd need to embed lua lol)

@fasterthanlime

This comment has been minimized.

Show comment
Hide comment
@fasterthanlime

fasterthanlime Dec 19, 2015

Member

There's a discussion going on in the itch community forums as well: http://itch.io/t/11981/lve-2d-love-file-support

Member

fasterthanlime commented Dec 19, 2015

There's a discussion going on in the itch community forums as well: http://itch.io/t/11981/lve-2d-love-file-support

@fasterthanlime

This comment has been minimized.

Show comment
Hide comment
@fasterthanlime

fasterthanlime Jan 8, 2016

Member

but then you'd need to embed lua lol

..or just a lua parser! luaparse is only 90k with deps, 23k zipped.

Member

fasterthanlime commented Jan 8, 2016

but then you'd need to embed lua lol

..or just a lua parser! luaparse is only 90k with deps, 23k zipped.

@LiamDawe

This comment has been minimized.

Show comment
Hide comment
@LiamDawe

LiamDawe Jan 14, 2016

An alternative is to get people using a launcher file if they aren't using a normal executable, Steam does this.

LiamDawe commented Jan 14, 2016

An alternative is to get people using a launcher file if they aren't using a normal executable, Steam does this.

@fasterthanlime

This comment has been minimized.

Show comment
Hide comment
@fasterthanlime

fasterthanlime Jan 14, 2016

Member

An alternative is ...

So do we, we launch .bat files in priority on Windows, and .sh on Linux and OSX in the absence of an .app bundle

Member

fasterthanlime commented Jan 14, 2016

An alternative is ...

So do we, we launch .bat files in priority on Windows, and .sh on Linux and OSX in the absence of an .app bundle

@nunodonato

This comment has been minimized.

Show comment
Hide comment
@nunodonato

nunodonato Jan 26, 2016

I just posted on the forum before checking this page!

Maybe how about starting with an easy(fast) solution and then improve it over time? For now, any .love game will not work in linux. Instead of bundling dependencies, or trying to install stuff, just assume that the developer has notified that love needs to be installed, and run "love file.love" from the itch.io app. Probably it will be easy to detect if "love" is a valid command or not, and notify the user if its not installed.

nunodonato commented Jan 26, 2016

I just posted on the forum before checking this page!

Maybe how about starting with an easy(fast) solution and then improve it over time? For now, any .love game will not work in linux. Instead of bundling dependencies, or trying to install stuff, just assume that the developer has notified that love needs to be installed, and run "love file.love" from the itch.io app. Probably it will be easy to detect if "love" is a valid command or not, and notify the user if its not installed.

@fasterthanlime

This comment has been minimized.

Show comment
Hide comment
@fasterthanlime

fasterthanlime Jan 26, 2016

Member

Maybe how about starting with an easy(fast) solution and then improve it over time?

👍

Member

fasterthanlime commented Jan 26, 2016

Maybe how about starting with an easy(fast) solution and then improve it over time?

👍

@Alloyed

This comment has been minimized.

Show comment
Hide comment
@Alloyed

Alloyed Jun 6, 2016

Assuming itch wants users to provide their own love install, it might be fine to ignore version numbers entirely:

  1. Most users will only have the latest stable version of love installed
  2. There is no standard way to have multiple love installs side-by-side
  3. Opening a .love file in the wrong version of love will generate a warning anyways

so for the times that doing love the-game.love doesn't work the best thing you can do is to get the user to resolve the situation themselves by manually pointing to a different version of love/using a wrapper script.

Alloyed commented Jun 6, 2016

Assuming itch wants users to provide their own love install, it might be fine to ignore version numbers entirely:

  1. Most users will only have the latest stable version of love installed
  2. There is no standard way to have multiple love installs side-by-side
  3. Opening a .love file in the wrong version of love will generate a warning anyways

so for the times that doing love the-game.love doesn't work the best thing you can do is to get the user to resolve the situation themselves by manually pointing to a different version of love/using a wrapper script.

@aaronfranke

This comment has been minimized.

Show comment
Hide comment
@aaronfranke

aaronfranke Aug 14, 2018

Considering you just released a .love game you may wish to make this a higher priority. It's a bit silly for the Itch app to not support the apps from the creator of the Itch app 😛

aaronfranke commented Aug 14, 2018

Considering you just released a .love game you may wish to make this a higher priority. It's a bit silly for the Itch app to not support the apps from the creator of the Itch app 😛

@fasterthanlime

This comment has been minimized.

Show comment
Hide comment
@fasterthanlime

fasterthanlime Sep 18, 2018

Member

Closing in favor of #808

Member

fasterthanlime commented Sep 18, 2018

Closing in favor of #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment