Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Nothing that can be launched was found" for tar.gz archives #2175

Open
dos1 opened this issue Oct 23, 2018 · 5 comments

Comments

@dos1
Copy link

commented Oct 23, 2018

Due to itchio/butler#48, I'm pushing my GNU/Linux builds as tar.gz archives with butler to itch.io.

One example: https://dos.itch.io/odlot

However, since v25, the Itch app can't handle it.

screenshot_20181023_161817

Clicking "Show in file manager" reveals that there's just one unpacked tar.gz file placed into the game directory.

Launching the game works fine on Itch v23. Also, tar.gz builds uploaded manually via the Web work fine on both versions, only butler ones are problematic.

@fasterthanlime

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

So, here's the situation:

  • v23 was overzealous in extracting nested archives: it was happy to extract a .rar in a .zip, for example, and that caused problems further down the line
  • v25 tries not to do that - it has one exception: a windows setup program in an archive will get run, not just extracted
  • for the situation you describe (which I really, really don't recommend as a workaround - pushing a .tar.gz defeats patching almost completely - but then again I haven't implemented .tar.gz generation server-side yet, so..), itch v25 should notice that a single file has been pushed, download that instead, notice that it's a .tar.gz, and extract it.

If it doesn't do that, then it's a bug and that should be investigated. I'm thinking maybe it does that on initial install, but not when upgrading? I'll have to dig into this.

@dos1

This comment has been minimized.

Copy link
Author

commented Oct 23, 2018

This was a fresh install - today was the first time I launched Itch client since that game was released ;)

@dos1

This comment has been minimized.

Copy link
Author

commented Feb 7, 2019

itch v25 should notice that a single file has been pushed, download that instead, notice that it's a .tar.gz, and extract it.

It still doesn't work :(

@hugga-bean

This comment has been minimized.

Copy link

commented May 14, 2019

Just encountered this issue with a different game. Selecting install in the itch app downloaded the tar.gz but did not extract the contents.

Running version 25.4.0 on an up-to-date Arch Linux install. If there are any other details I can provide, please let me know.

@fasterthanlime

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@hugga-bean I had to revert those changes - it broke other functionality.

My hope is to enable generation of .tar.gz archives in the backend soon, and then seamlessly extract .tar.gz archive while pushing (like we do .zip).

In the meantime, pushing .tar.gz files with butler will 1) serve .tar.gz files to web downloaders 2) make it impossible to launch from the itch app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.