Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Nothing that can be launched was found" for tar.gz archives #2175

Open
dos1 opened this issue Oct 23, 2018 · 7 comments
Open

"Nothing that can be launched was found" for tar.gz archives #2175

dos1 opened this issue Oct 23, 2018 · 7 comments

Comments

@dos1
Copy link

@dos1 dos1 commented Oct 23, 2018

Due to itchio/butler#48, I'm pushing my GNU/Linux builds as tar.gz archives with butler to itch.io.

One example: https://dos.itch.io/odlot

However, since v25, the Itch app can't handle it.

screenshot_20181023_161817

Clicking "Show in file manager" reveals that there's just one unpacked tar.gz file placed into the game directory.

Launching the game works fine on Itch v23. Also, tar.gz builds uploaded manually via the Web work fine on both versions, only butler ones are problematic.

@fasterthanlime
Copy link
Collaborator

@fasterthanlime fasterthanlime commented Oct 23, 2018

So, here's the situation:

  • v23 was overzealous in extracting nested archives: it was happy to extract a .rar in a .zip, for example, and that caused problems further down the line
  • v25 tries not to do that - it has one exception: a windows setup program in an archive will get run, not just extracted
  • for the situation you describe (which I really, really don't recommend as a workaround - pushing a .tar.gz defeats patching almost completely - but then again I haven't implemented .tar.gz generation server-side yet, so..), itch v25 should notice that a single file has been pushed, download that instead, notice that it's a .tar.gz, and extract it.

If it doesn't do that, then it's a bug and that should be investigated. I'm thinking maybe it does that on initial install, but not when upgrading? I'll have to dig into this.

Loading

@dos1
Copy link
Author

@dos1 dos1 commented Oct 23, 2018

This was a fresh install - today was the first time I launched Itch client since that game was released ;)

Loading

@dos1
Copy link
Author

@dos1 dos1 commented Feb 7, 2019

itch v25 should notice that a single file has been pushed, download that instead, notice that it's a .tar.gz, and extract it.

It still doesn't work :(

Loading

@apinksmurfette
Copy link

@apinksmurfette apinksmurfette commented May 14, 2019

Just encountered this issue with a different game. Selecting install in the itch app downloaded the tar.gz but did not extract the contents.

Running version 25.4.0 on an up-to-date Arch Linux install. If there are any other details I can provide, please let me know.

Loading

@fasterthanlime
Copy link
Collaborator

@fasterthanlime fasterthanlime commented May 15, 2019

@hugga-bean I had to revert those changes - it broke other functionality.

My hope is to enable generation of .tar.gz archives in the backend soon, and then seamlessly extract .tar.gz archive while pushing (like we do .zip).

In the meantime, pushing .tar.gz files with butler will 1) serve .tar.gz files to web downloaders 2) make it impossible to launch from the itch app.

Loading

@jontopielski
Copy link

@jontopielski jontopielski commented Feb 26, 2020

Me and 1 other person are seeing this issue on itch 25.4.0, butler 15.17.3 and itch-setup 1.18.0 for one of the games I uploaded to itch. We're both running macOS.

Screen Shot 2020-02-25 at 9 24 44 PM

Here's the .itch/receipt.json.gz if it's any help:

   "game":{
      "id":571621,
      "url":"https://jontopielski.itch.io/portalbot",
      "title":"Portal Bot",
      "shortText":"challenging platformer about shooting portals",
      "type":"html",
      "classification":"game",
      "embed":{
         "gameId":0,
         "width":960,
         "height":540,
         "fullscreen":true
      },
      "coverUrl":"https://img.itch.zone/aW1nLzMwMjE5OTkuZ2lm/315x250%23c/iERjAA.gif",
      "stillCoverUrl":"https://img.itch.zone/aW1nLzMwMjE5OTkuZ2lm/315x250%23cm/zvcVVA.gif",
      "createdAt":"2020-02-19T06:58:51Z",
      "publishedAt":"2020-02-23T07:46:14Z",
      "platforms":{
         "windows":"all",
         "linux":"all",
         "osx":"all"
      },
      "user":{
         "id":1525436,
         "username":"jontopielski",
         "displayName":"Jon Topielski",
         "developer":false,
         "pressUser":false,
         "url":"https://jontopielski.itch.io",
         "coverUrl":"https://img.itch.zone/aW1nLzI4NjcxNzAucG5n/100x100%23/c4ykaR.png",
         "stillCoverUrl":""
      }
   },
   "upload":{
      "id":1982418,
      "storage":"hosted",
      "filename":"PortalBot.dmg.zip",
      "displayName":"PortalBotMac.dmg.zip",
      "size":23315960,
      "channelName":"",
      "build":null,
      "type":"default",
      "preorder":false,
      "demo":false,
      "platforms":{
         "osx":"all"
      },
      "createdAt":"2020-02-23T07:37:52Z",
      "updatedAt":"2020-02-23T07:39:56Z"
   },
   "build":null,
   "files":[
      "PortalBot.dmg",
      "__MACOSX/._PortalBot.dmg"
   ],
   "installerName":"archive"
}```

Loading

@fasterthanlime
Copy link
Collaborator

@fasterthanlime fasterthanlime commented Feb 26, 2020

@jontopielski This is not an itch bug. A .dmg file is already a single-file archive, and you compressed it as a zip, so there's two layers of archives there, which itch no longer handles (it used to, and it was brittle, so it was removed).

Speaking of .dmg, itch v26 will remove support for those, along with Windows installers. But it'll have a gentler failure mode: instead of showing a "No launch targets found" dialog like that, it'll just open the install folder in the File Explorer / Finder / etc., and hopefully users will double-click their way to having a working copy of the game. "Launch" still won't do the right thing the next time, but there's no way to automatically detect that, so.

What I recommend to upload macOS app bundles is:

  • Don't bother with a .dmg, or .pkg, or .tar.gz, or .7z, or .rar, or anything
  • Just use butler push as recommended

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants