From 73fc6e49dd5a3da7ab16a2c1aa0e2897a80321a1 Mon Sep 17 00:00:00 2001 From: Alan Cha Date: Fri, 3 Nov 2023 10:53:08 -0400 Subject: [PATCH] Suggestions Signed-off-by: Alan Cha --- docs/tutorials/integrations/kserve-mm/canary.md | 2 +- docs/tutorials/integrations/kserve/canary.md | 2 +- .../integrations/kubernetes-gateway-api/blue-green.md | 6 +++--- .../integrations/kubernetes-gateway-api/canary.md | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/tutorials/integrations/kserve-mm/canary.md b/docs/tutorials/integrations/kserve-mm/canary.md index 305ef950..6f6d0b7b 100644 --- a/docs/tutorials/integrations/kserve-mm/canary.md +++ b/docs/tutorials/integrations/kserve-mm/canary.md @@ -96,7 +96,7 @@ cat grpc_input.json \ inference.GRPCInferenceService.ModelInfer \ | grep -e app-version ``` -4. Requests can also be sent with the header `traffic: test`. When a candidate is deployed, requests with this header will be routed to the candidate. When no candidate is deployed, all requests will be routed to the same model version. +4. Requests can also be sent with the header `traffic: test`. When a candidate is deployed, requests with this header will be routed to the candidate. When no candidate is deployed, all requests will be routed to the primary version. ```shell cat grpc_input.json \ | grpcurl -vv -plaintext -proto kserve.proto -d @ \ diff --git a/docs/tutorials/integrations/kserve/canary.md b/docs/tutorials/integrations/kserve/canary.md index 5d61e18a..23f3cf89 100644 --- a/docs/tutorials/integrations/kserve/canary.md +++ b/docs/tutorials/integrations/kserve/canary.md @@ -90,7 +90,7 @@ http://wisdom.default -d @input.json -s -D - \ | grep -e HTTP -e app-version ``` -4. Requests can also be sent with the header `traffic: test`. When a candidate is deployed, requests with this header will be routed to the candidate. When no candidate is deployed, all requests will be routed to the same model version. +4. Requests can also be sent with the header `traffic: test`. When a candidate is deployed, requests with this header will be routed to the candidate. When no candidate is deployed, all requests will be routed to the primary version. ```shell curl -H 'Content-Type: application/json' \ -H 'traffic: test' \ diff --git a/docs/tutorials/integrations/kubernetes-gateway-api/blue-green.md b/docs/tutorials/integrations/kubernetes-gateway-api/blue-green.md index 57880ae2..7089032d 100644 --- a/docs/tutorials/integrations/kubernetes-gateway-api/blue-green.md +++ b/docs/tutorials/integrations/kubernetes-gateway-api/blue-green.md @@ -25,10 +25,10 @@ This tutorial uses the Kubernetes Gateway API to allow the use any service mesh ## Deploy initial version -Deploy the initial version of the application ([httpbin](https://httpbin.org/))using the Iter8 `release` chart by identifying the environment into which it should be deployed, a list of the versions to be deployed (only one here), and the rollout strategy to be used. Note that we deploy the application to the namespace `test`. +Deploy the initial version of the application ([httpbin](https://httpbin.org/)) using the Iter8 `release` chart by identifying the environment into which it should be deployed, a list of the versions to be deployed (only one here), and the rollout strategy to be used. Note that we deploy the application to the namespace `test`. -???+ note "About creating a namespace for linkerd deployments" - When creating a namespace, it should be annotated so that all created pods are injected with the linkerd proxy. This can be done, for example, by using the linkerd CLI: +???+ note "About creating a namespace for Linkerd deployments" + When creating a namespace, it should be annotated so that all created pods are injected with the Linkerd proxy. This can be done, for example, by using the Linkerd CLI: ```shell kubectl create ns test --dry-run=client -o yaml | linkerd inject - | kubectl apply -f - ``` diff --git a/docs/tutorials/integrations/kubernetes-gateway-api/canary.md b/docs/tutorials/integrations/kubernetes-gateway-api/canary.md index ce126aeb..a2c14ed8 100644 --- a/docs/tutorials/integrations/kubernetes-gateway-api/canary.md +++ b/docs/tutorials/integrations/kubernetes-gateway-api/canary.md @@ -25,10 +25,10 @@ This tutorial uses the Kubernetes Gateway API to allow the use any service mesh ## Deploy initial version -Deploy the initial version of the application ([httpbin](https://httpbin.org/))using the Iter8 `release` chart by identifying the environment into which it should be deployed, a list of the versions to be deployed (only one here), and the rollout strategy to be used. Note that we deploy the application to the namespace `test`. +Deploy the initial version of the application ([httpbin](https://httpbin.org/)) using the Iter8 `release` chart by identifying the environment into which it should be deployed, a list of the versions to be deployed (only one here), and the rollout strategy to be used. Note that we deploy the application to the namespace `test`. -???+ note "About creating a namespace for linkerd deployments" - When creating a namespace, it should be annotated so that all created pods are injected with the linkerd proxy. This can be done, for example, by using the linkerd CLI: +???+ note "About creating a namespace for Linkerd deployments" + When creating a namespace, it should be annotated so that all created pods are injected with the Linkerd proxy. This can be done, for example, by using the Linkerd CLI: ```shell kubectl create ns test --dry-run=client -o yaml | linkerd inject - | kubectl apply -f - ``` @@ -82,7 +82,7 @@ kubectl exec --stdin --tty "$(kubectl get pod --sort-by={metadata.creationTimest curl httpbin.test -s -D - | grep -e '^HTTP' -e app-version ``` -4. Requests can also be sent with the header `traffic: test`. When a candidate is deployed, requests with this header will be routed to the candidate. When no candidate is deployed, all requests will be routed to the same model version. +4. Requests can also be sent with the header `traffic: test`. When a candidate is deployed, requests with this header will be routed to the candidate. When no candidate is deployed, all requests will be routed to the primary version. ```shell curl httpbin.test -H 'traffic: test' -s -D - | grep -e '^HTTP' -e app-version ```