Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health checker blocks the shepherd if docker registry is inaccessible #62

Closed
blazekadam opened this issue Jan 23, 2019 · 2 comments · Fixed by #65
Closed

Health checker blocks the shepherd if docker registry is inaccessible #62

blazekadam opened this issue Jan 23, 2019 · 2 comments · Fixed by #65
Assignees
Labels
bug Something isn't working

Comments

@blazekadam
Copy link
Contributor

It is possible that this issue is reproducible only from within a docker.

Most likely, it's this line

response = requests.get(config.url + "/v2/_catalog", auth=HTTPBasicAuth(config.username, config.password))

perhaps an explicit timeout would do the job

@blazekadam blazekadam added the bug Something isn't working label Jan 23, 2019
@janbuchar
Copy link
Contributor

Nah, we'll switch over to the http client provided by aiohttp and ditch requests. Shame on me for forgetting to rewrite this...

@blazekadam
Copy link
Contributor Author

Ah, good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants